[Bug]: Filenames with # cannot be opened
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 30/100
Research direction
Start by reading StandardFolderProvider.GetFileUrl, which the issue identifies as the source of the filename handling. Reproduce the problem with a file named “My File Example #1.PDF” in the Asset manager and check how its URL is generated. Done means opening the file no longer returns a 404 because of the # character.
Written by the indexing model from the issue text.
Description
Is there an existing issue for this?
- I have searched the existing issues
What happened?
If I add a file with # in it's name, when I try to open-it throgh asset management it cannot be accessed.
Example: "My File Example #1.PDF"
I have checked using the APIs in the code and when I use the default FolderManager GetUrl method, it returns the fiilename without handling the # character that becomes invalid to use in the browser.
Steps to reproduce?
Go to Asset manager
Add a file with the filename: "My File Example #1.PDF"
Right click on the file after upload
Chose the option Open
File will try to oned on a new tab bot a 404 page is displayed because of the # in the URL
Current Behavior
No response
Expected Behavior
I think that the StandardFolderProvider implementation of GetFileUrl should handle the # as any of the other InvalidFileUrlChars and render a LinkCLick url for the file instead of the direct link.
Or replace the # char with %23
Relevant log output
Anything else?
No response
Affected Versions
10.2.0 (latest v10 release)
What browsers are you seeing the problem on?
No response
Code of Conduct
- I agree to follow this project's Code of Conduct
- Dominant language
- C#
- Stars
- 1.1k
- Forks
- 791
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 24
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dnnsoftware/Dnn.Platform
-
[Bug]: Edit Bar buttons are not localizedPossibly taken @idumlupinar claimed this 1 day ago. OpenStatus: New
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
dnnsoftware/Dnn.Platform#7565 ·
Maintainers usually reply within 1 day
-
Status: New
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
dnnsoftware/Dnn.Platform#7543 · 3 comments ·
Maintainers usually reply within 1 day
-
Status: New
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
dnnsoftware/Dnn.Platform#6681 ·
Maintainers usually reply within 1 day
-
Status: New
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
dnnsoftware/Dnn.Platform#6051 · 4 comments ·
Maintainers usually reply within 1 day
-
Status: New
Difficulty 3/5 1-2 days Newbie friendliness 45/100
dnnsoftware/Dnn.Platform#7555 ·
Maintainers usually reply within 1 day
All issues in dnnsoftware/Dnn.Platform
Similar issues
-
python triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
microsoft/semantic-kernel#14615 ·
Maintainers usually reply within 3 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
fboucher/2d6-dungeon-app#245 · 1 comment ·
Maintainers usually reply within 1 day
-
needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
7.0
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
unoplatform/uno.extensions#3253 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Sector-Vestige/Sector-Vestige#476 ·
Maintainers usually reply within 1 day