Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

fix(review): resolve suffix-only paths and check paths in finding quotes and suggestions

Open
  • Is something wrong?
#1,094 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

A pull request for this has already been merged.

  • #1134 by @devops-thiago — merged

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
58/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
github, java
Domain
backend, testing-qa

Research direction

Read the tests covering review path validation and the code that maps paths and checks findings and suggestions; the issue does not name specific files. Reproduce the three referenced cases from #1076 and #1089, then add tests for suffix-only paths, paths quoted in findings, and unresolved suggestion paths. Done when all three cases pass and no finding is dropped.

Written by the indexing model from the issue text.

Description

bug

Background

Follow-up to #1076 (#1089). Round 18 had no invented files in summary prose, but three gaps remain:

  • Paths without their language folder: c ThrillhouseBot-test#277 writes docs/CONFIG-C.md (file is c/docs/CONFIG-C.md, review 5497696891), node #278 writes src/config.ts (review 5497680136). They pass the check because they are suffixes of real paths.
  • A wrong path inside finding text: zig #274 finding 4253724449 quotes the Dockerfile destination as /usr/local/bin/gcompressed-server.
  • Suggestions are not checked: kotlin #276 suggestion 4253725124 uses /app/lib/*, which nothing creates.

Change required

Map a suffix-only path to the full changed path when exactly one changed file ends with it. Extend the check to paths quoted from changed files (a path a finding attributes to a file must appear in that file's patch) and to suggestion text, dropping the suggestion (not the finding) when it names a path that resolves nowhere.

Acceptance criteria

  • Tests for the three cases above.
  • No finding is dropped.
Dominant language
Java
Stars
35
Forks
7
Avg merge
9h 45m
Merged PRs (30d)
160

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from devops-thiago/ThrillhouseBot

All issues in devops-thiago/ThrillhouseBot

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.