[Bug]: normalize_url lowercases the userinfo in a URL, so credentials in a link are rewritten

Offen
#2,529 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@Steve-20-ai arbeitet bereits daran.

Seit 10.11.2026.

  • #2530 von @Steve-20-ai — offen

Bewertung

Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Anfängerfreundlichkeit
20/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
python
Bereich
backend

Rechercherichtung

Read the three normalizers named in the issue: normalize_url, normalize_url_for_deep_crawl, and efficient_normalize_url_for_deep_crawl. Check how each handles parsed.netloc and add regression coverage for preserved userinfo casing and lowercase hostnames. The issue says the author has a patch and six tests ready, and linked PR #2530 is open.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Describe the bug

normalize_url, normalize_url_for_deep_crawl and efficient_normalize_url_for_deep_crawl all lowercase the whole netloc:

netloc = parsed.netloc.lower()

netloc also carries the user:password@ part of a URL. A hostname is case-insensitive, so lowering it is right; credentials are not, so the same call silently rewrites them. The comment on the efficient normalizer even says what was intended — # 1. Lowercase hostname.

Steps to Reproduce

from crawl4ai.utils import normalize_url, normalize_url_for_deep_crawl

base = "https://example.com/dir/page"
print(normalize_url("https://User:[email protected]/path", base))
print(normalize_url_for_deep_crawl("https://User:[email protected]/path", base))

Actual:

https://user:[email protected]/path
https://user:[email protected]/path

Expected:

https://User:[email protected]/path
https://User:[email protected]/path

Why it matters

quick_extract_links resolves every <a href> through normalize_url_for_deep_crawl, so any link carrying credentials in its URL is rewritten before the crawl follows it. A page that links to https://user:SecRet@host/ is then fetched with user:secret, and the server answers 401 — or, worse, authenticates as a different account on systems where the userinfo is an identifier rather than a password. The same happens to URLs assembled by hand and passed to the deep-crawl path.

Environment

  • crawl4ai main at cae74b2
  • Python 3.13, Windows
  • No browser involved: the three functions are pure string handling

Proposed patch

Lowercase only the host, keeping whatever precedes the @ as written:

def _lowercase_host(netloc: str) -> str:
    userinfo, separator, hostport = netloc.rpartition('@')
    return f"{userinfo}{separator}{hostport.lower()}"

rpartition keeps a %40-encoded @ inside the password intact, since urlparse leaves it encoded in the netloc. Used at the three call sites, the diff is one line each.

Behaviour for URLs without userinfo is unchanged, including the port: Example.COM:8080 still becomes example.com:8080.

I have the patch and six regression tests ready (userinfo casing, host-only casing, userinfo with port, encoded @ in the password, and the two deep-crawl normalizers) and will open the PR against this issue.

Vorherrschende Sprache
Python
Sterne
87.2k
Forks
9.1k
Ø Merge
1 T. 6 Std.
Gemergte PRs (30 T.)
25

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus unclecode/crawl4ai

Alle Issues in unclecode/crawl4ai

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.