[Bug]: normalize_url lowercases the userinfo in a URL, so credentials in a link are rewritten
Maintainer antworten meist innerhalb von 1 Tag
Bewertung
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Anfängerfreundlichkeit
- 20/100
Rechercherichtung
Read the three normalizers named in the issue: normalize_url, normalize_url_for_deep_crawl, and efficient_normalize_url_for_deep_crawl. Check how each handles parsed.netloc and add regression coverage for preserved userinfo casing and lowercase hostnames. The issue says the author has a patch and six tests ready, and linked PR #2530 is open.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Describe the bug
normalize_url, normalize_url_for_deep_crawl and efficient_normalize_url_for_deep_crawl all lowercase the whole netloc:
netloc = parsed.netloc.lower()
netloc also carries the user:password@ part of a URL. A hostname is case-insensitive, so lowering it is right; credentials are not, so the same call silently rewrites them. The comment on the efficient normalizer even says what was intended — # 1. Lowercase hostname.
Steps to Reproduce
from crawl4ai.utils import normalize_url, normalize_url_for_deep_crawl
base = "https://example.com/dir/page"
print(normalize_url("https://User:[email protected]/path", base))
print(normalize_url_for_deep_crawl("https://User:[email protected]/path", base))
Actual:
https://user:[email protected]/path
https://user:[email protected]/path
Expected:
https://User:[email protected]/path
https://User:[email protected]/path
Why it matters
quick_extract_links resolves every <a href> through normalize_url_for_deep_crawl, so any link carrying credentials in its URL is rewritten before the crawl follows it. A page that links to https://user:SecRet@host/ is then fetched with user:secret, and the server answers 401 — or, worse, authenticates as a different account on systems where the userinfo is an identifier rather than a password. The same happens to URLs assembled by hand and passed to the deep-crawl path.
Environment
crawl4aimainatcae74b2- Python 3.13, Windows
- No browser involved: the three functions are pure string handling
Proposed patch
Lowercase only the host, keeping whatever precedes the @ as written:
def _lowercase_host(netloc: str) -> str:
userinfo, separator, hostport = netloc.rpartition('@')
return f"{userinfo}{separator}{hostport.lower()}"
rpartition keeps a %40-encoded @ inside the password intact, since urlparse leaves it encoded in the netloc. Used at the three call sites, the diff is one line each.
Behaviour for URLs without userinfo is unchanged, including the port: Example.COM:8080 still becomes example.com:8080.
I have the patch and six regression tests ready (userinfo casing, host-only casing, userinfo with port, encoded @ in the password, and the two deep-crawl normalizers) and will open the PR against this issue.
- Vorherrschende Sprache
- Python
- Sterne
- 87.2k
- Forks
- 9.1k
- Ø Merge
- 1 T. 6 Std.
- Gemergte PRs (30 T.)
- 25
Entwicklungsumgebung
- Enthält ein Dockerfile oder eine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus unclecode/crawl4ai
-
BUG: UserAgentGenerator.generate ignores browser_type and returns a random browser stackEvtl. vergeben @HhH666-ux hat das heute übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 85/100
Maintainer antworten meist innerhalb von 1 Tag
-
[Bug]: Hardened docker-compose (read_only) keeps full Chromium from starting: crashpad needs a writable ~/.configEvtl. vergeben Ein verknüpfter Pull Request ist offen oder bereits gemergt. Offen🐞 Bug 📌 Root caused
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
unclecode/crawl4ai#2494 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
[Feature]: Crawl4aiDockerClient has no public option for the API token the 0.9 server requiresOffen⚙ Done ✨ Enhancement
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 77/100
Maintainer antworten meist innerhalb von 1 Tag
-
⚙ Done 🐞 Bug 📌 Root caused
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
Maintainer antworten meist innerhalb von 1 Tag
-
[Bug]: PDF images saved with save_images_locally=True come back with an empty src in result.mediaOffen⚙ Done 🐞 Bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
unclecode/crawl4ai#2469 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in unclecode/crawl4ai
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 73/100
Netcracker/qubership-ai-packages#266 ·
Maintainer antworten meist innerhalb von 1 Tag
-
PROCESSED_DATA_FOLDER: strip whitespace and treat empty as unsetEvtl. vergeben @TorecLuik hat das heute übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 84/100
NL-BioImaging/BIOMERO.importer#63 ·
Maintainer antworten meist innerhalb von 1 Tag
-
MLX training-complete chat/merge suggestions omit --backend mlxEvtl. vergeben @vaputa hat das heute übernommen. Offenneeds-triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
MakazhanAlpamys/Soup#2913 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
area:security effort:S priority:P3 status:needs-triage type:chore
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
randomparity/kdive#3657 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
aws/mcp-proxy-for-aws#476 ·
Maintainer antworten meist innerhalb von 1 Tag