[Bug]: normalize_url lowercases the userinfo in a URL, so credentials in a link are rewritten

未关闭
#2,529 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@Steve-20-ai 已经在做这个了。

开始于 2026年11月10日。

  • #2530 来自 @Steve-20-ai —— 未关闭

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
20/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
python
领域
backend

调研方向

Read the three normalizers named in the issue: normalize_url, normalize_url_for_deep_crawl, and efficient_normalize_url_for_deep_crawl. Check how each handles parsed.netloc and add regression coverage for preserved userinfo casing and lowercase hostnames. The issue says the author has a patch and six tests ready, and linked PR #2530 is open.

由索引模型根据 Issue 内容生成。

描述

Describe the bug

normalize_url, normalize_url_for_deep_crawl and efficient_normalize_url_for_deep_crawl all lowercase the whole netloc:

netloc = parsed.netloc.lower()

netloc also carries the user:password@ part of a URL. A hostname is case-insensitive, so lowering it is right; credentials are not, so the same call silently rewrites them. The comment on the efficient normalizer even says what was intended — # 1. Lowercase hostname.

Steps to Reproduce

from crawl4ai.utils import normalize_url, normalize_url_for_deep_crawl

base = "https://example.com/dir/page"
print(normalize_url("https://User:[email protected]/path", base))
print(normalize_url_for_deep_crawl("https://User:[email protected]/path", base))

Actual:

https://user:[email protected]/path
https://user:[email protected]/path

Expected:

https://User:[email protected]/path
https://User:[email protected]/path

Why it matters

quick_extract_links resolves every <a href> through normalize_url_for_deep_crawl, so any link carrying credentials in its URL is rewritten before the crawl follows it. A page that links to https://user:SecRet@host/ is then fetched with user:secret, and the server answers 401 — or, worse, authenticates as a different account on systems where the userinfo is an identifier rather than a password. The same happens to URLs assembled by hand and passed to the deep-crawl path.

Environment

  • crawl4ai main at cae74b2
  • Python 3.13, Windows
  • No browser involved: the three functions are pure string handling

Proposed patch

Lowercase only the host, keeping whatever precedes the @ as written:

def _lowercase_host(netloc: str) -> str:
    userinfo, separator, hostport = netloc.rpartition('@')
    return f"{userinfo}{separator}{hostport.lower()}"

rpartition keeps a %40-encoded @ inside the password intact, since urlparse leaves it encoded in the netloc. Used at the three call sites, the diff is one line each.

Behaviour for URLs without userinfo is unchanged, including the port: Example.COM:8080 still becomes example.com:8080.

I have the patch and six regression tests ready (userinfo casing, host-only casing, userinfo with port, encoded @ in the password, and the two deep-crawl normalizers) and will open the PR against this issue.

主要语言
Python
星标
87.2k
派生
9.1k
平均合并
1 天 6 小时
30 天内合并 PR
25

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

unclecode/crawl4ai 的其他 Issue

查看 unclecode/crawl4ai 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。