Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

serverFunctions.components: CSS below a use server boundary is missing from production client assets (rc.15 / next)

Offen
#456 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
56/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
typescript, vite

Rechercherichtung

Start with the referenced client transform in packages/compiler/src/directives/transform.rs and the plugin’s server-functions handling in src/server-functions/index.ts; then compare production manifest loading in src/index.ts with dev CSS collection in src/dev-manifest.ts. Reproduce with the supplied minimal app using bunx vite build and check the client manifest and production SSR output. Done means the server component’s CSS is represented in production assets and appears on both document loads and frame navigation, with the reported reproduction styled.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

CSS imported only below a module-level 'use server' boundary is not delivered to the browser in production SSR start mode with serverFunctions: { components: true }. The server component's HTML is present, but its CSS is absent on both document loads and subsequent frame requests. Plain Vite reproduces this without Cloudflare or Vite+.

Versions tested

  • Published: solid-js, @solidjs/web, @solidjs/signals, @solidjs/compiler, and @solidjs/babel-plugin 2.0.0-rc.15; @solidjs/vite-plugin 3.0.0-next.50.
  • Source builds of both next branches:
    • solidjs/solid: 2aa9e86ada5beb33211f60260c59234bbcf14899 (local Signals, Solid, Web/frames, Babel plugin, and a locally compiled native compiler).
    • solidjs/solid-vite-plugin: ec6b58d0c17290d6f474a9ed93bfa03d1dc9b8a0.
  • Both: plain vite 8.3.4, Bun 1.4.2, Node 26.12.0, macOS arm64; browser checks with playwright-core 1.64.1 and system Google Chrome 155.0.8059.85 (channel: 'chrome').

The published versions were resolved from solid-js@next, @solidjs/web@next, and @solidjs/vite-plugin@latest; the plugin's next tag currently points to an older release.

Minimal reproduction

Start with an empty directory and package.json containing {"private":true,"type":"module"}, then:

bun add solid-js@next @solidjs/web@next @solidjs/vite-plugin@latest vite
// vite.config.ts
import { defineConfig } from 'vite';
import solid from '@solidjs/vite-plugin';
export default defineConfig({
  plugins: [solid({ start: true, ssr: true,
    serverFunctions: { components: true }, performanceTracks: false })],
});

// src/App.tsx
import { createSignal, Loading } from 'solid-js';
import { dynamic, getRequestEvent, isServer } from '@solidjs/web';
import { getNotes } from './server';
function PageB() {
  const Notes = dynamic(() => getNotes());
  return <Loading fallback={<p>Loading...</p>}><Notes /></Loading>;
}
export default function App() {
  const url = isServer ? getRequestEvent()!.request.url : location.href;
  const [page, setPage] = createSignal(new URL(url).pathname === '/b' ? 'b' : 'a');
  return <main>
    <button id="to-a" onClick={() => setPage('a')}>Page A</button>
    <button id="to-b" onClick={() => setPage('b')}>Page B</button>
    {page() === 'b' ? <PageB /> : <p>Plain page A</p>}
  </main>;
}

// src/server.tsx
'use server';
import { Notes } from './notes';
export async function getNotes() { return () => <Notes />; }

// src/notes.tsx — imported ONLY by server.tsx
import './notes.css';
export function Notes() {
  return <div id="notes" class="notes">Server-only notes</div>;
}
/* src/notes.css */
.notes { color: rgb(255, 0, 0); background-color: rgb(255, 255, 0); }

No authored entries, router, custom manifest, optimizeDeps exclusions, or css.filter settings are required. For the linked HEAD package check, I used start: { devtools: false } to disable the optional devtools detected in the plugin checkout; the production result is the same.

Steps and results

The following results are the same for the published packages and the two source-built HEADs:

  1. Build: bunx vite build. Expected: the server component's stylesheet is available as a browser-served asset (or inline CSS) and represented in the relevant asset collection. Actual: no notes CSS under dist/client, no notes CSS entry in dist/client/.vite/manifest.json. With plain Vite's default SSR asset settings, this minimal repro emits no standalone CSS under dist/server either. The CSS Module variant still embeds the hashed class string in the server output.
  2. Production document: bunx vite preview --host 127.0.0.1 --port 5200 --strictPort, then open /b in a fresh browser context. Expected: red notes. Actual: HTTP 200, raw SSR HTML contains #notes, but no stylesheet link or inline rule; getComputedStyle(document.querySelector('#notes')).color is rgb(0, 0, 0). Boot makes zero /_server requests, so document adoption itself works.
  3. Production client navigation: in another fresh browser context, open /a and click Page B. Expected: red notes, with styles delivered before reveal if they were not already loaded. Actual: a successful application/x-frame-stream response from /_server/data/getNotes-d166722e contains start, html, complete, but no assets record / styles. The element appears with black text. There are no page/console errors in these production checks.
  4. Dev: run bunx vite --host 127.0.0.1 --port 5201 --strictPort and repeat both browser paths. Actual: both are red. The initial document inlines the notes stylesheet in a <style data-asset="…/src/notes.css" data-vite-dev-id="…">, even on page A. The subsequent frame response still has no style assets, but this case already has the CSS. This dev/production difference hides the problem during development.

The CSS Module variant also reproduces: replace the import with import css from './notes.module.css' and use class={css.notes}. Production SSR and frame HTML contain a hashed class, e.g. _notes_5xr5i_1, with no matching stylesheet; dev is styled.

Workaround verified on both versions

With the plain .css variant above, also add import './notes.css' to src/App.tsx. The build then emits a client CSS asset, its manifest entry has css, the SSR document links it, and both production browser paths compute rgb(255, 0, 0). Dev also stays styled. This workaround eagerly loads the server component's styles through a client-owned import.

Design and source observations

I read the plugin README sections for serverFunctions, start, start.css.filter, and virtual:solid-manifest, plus the server-components docs. I did not find a documented requirement to repeat a server component's CSS import in a client module. css.filter is documented as development-only, and virtual:solid-manifest exposes the client build manifest in production.

The frame streams RFC, “4. Fragment assets and styles” describes assets with styles and style-gated reveal. This transport is present: frame-sink.ts, lines 565–577 emits CSS entries from meta.preloads as assets.styles.

The collection boundary appears to be earlier:

These are collection/transform observations, rather than a claim that the frames consumer rejects a supplied stylesheet. Should server-component CSS reached only through this boundary be collected for production as well, or is there an intended authoring pattern that should be documented?

Related context: #428 is my earlier report about a duplicated server-functions client in dev with optimizeDeps.exclude; this repro uses no exclusions and produces valid component HTML. Existing #414/#415 concern dev manifest timing/cache, and #425 concerns CSS ordering; those do not cover this production omission.

Vorherrschende Sprache
TypeScript
Sterne
522
Forks
73
Ø Merge
1 T. 8 Std.
Gemergte PRs (30 T.)
31

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus solidjs/solid-vite-plugin

Alle Issues in solidjs/solid-vite-plugin

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.