serverFunctions.components: CSS below a use server boundary is missing from production client assets (rc.15 / next)
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 56/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- typescript, vite
- 領域
- build-system, frontend
研究方向
Start with the referenced client transform in packages/compiler/src/directives/transform.rs and the plugin’s server-functions handling in src/server-functions/index.ts; then compare production manifest loading in src/index.ts with dev CSS collection in src/dev-manifest.ts. Reproduce with the supplied minimal app using bunx vite build and check the client manifest and production SSR output. Done means the server component’s CSS is represented in production assets and appears on both document loads and frame navigation, with the reported reproduction styled.
由索引模型根據 Issue 內容生成。
描述
CSS imported only below a module-level 'use server' boundary is not delivered to the browser in production SSR start mode with serverFunctions: { components: true }. The server component's HTML is present, but its CSS is absent on both document loads and subsequent frame requests. Plain Vite reproduces this without Cloudflare or Vite+.
Versions tested
- Published:
solid-js,@solidjs/web,@solidjs/signals,@solidjs/compiler, and@solidjs/babel-plugin2.0.0-rc.15;@solidjs/vite-plugin3.0.0-next.50. - Source builds of both
nextbranches:- solidjs/solid: 2aa9e86ada5beb33211f60260c59234bbcf14899 (local Signals, Solid, Web/frames, Babel plugin, and a locally compiled native compiler).
- solidjs/solid-vite-plugin: ec6b58d0c17290d6f474a9ed93bfa03d1dc9b8a0.
- Both: plain
vite8.3.4, Bun 1.4.2, Node 26.12.0, macOS arm64; browser checks withplaywright-core1.64.1 and system Google Chrome 155.0.8059.85 (channel: 'chrome').
The published versions were resolved from solid-js@next, @solidjs/web@next, and @solidjs/vite-plugin@latest; the plugin's next tag currently points to an older release.
Minimal reproduction
Start with an empty directory and package.json containing {"private":true,"type":"module"}, then:
bun add solid-js@next @solidjs/web@next @solidjs/vite-plugin@latest vite
// vite.config.ts
import { defineConfig } from 'vite';
import solid from '@solidjs/vite-plugin';
export default defineConfig({
plugins: [solid({ start: true, ssr: true,
serverFunctions: { components: true }, performanceTracks: false })],
});
// src/App.tsx
import { createSignal, Loading } from 'solid-js';
import { dynamic, getRequestEvent, isServer } from '@solidjs/web';
import { getNotes } from './server';
function PageB() {
const Notes = dynamic(() => getNotes());
return <Loading fallback={<p>Loading...</p>}><Notes /></Loading>;
}
export default function App() {
const url = isServer ? getRequestEvent()!.request.url : location.href;
const [page, setPage] = createSignal(new URL(url).pathname === '/b' ? 'b' : 'a');
return <main>
<button id="to-a" onClick={() => setPage('a')}>Page A</button>
<button id="to-b" onClick={() => setPage('b')}>Page B</button>
{page() === 'b' ? <PageB /> : <p>Plain page A</p>}
</main>;
}
// src/server.tsx
'use server';
import { Notes } from './notes';
export async function getNotes() { return () => <Notes />; }
// src/notes.tsx — imported ONLY by server.tsx
import './notes.css';
export function Notes() {
return <div id="notes" class="notes">Server-only notes</div>;
}
/* src/notes.css */
.notes { color: rgb(255, 0, 0); background-color: rgb(255, 255, 0); }
No authored entries, router, custom manifest, optimizeDeps exclusions, or css.filter settings are required. For the linked HEAD package check, I used start: { devtools: false } to disable the optional devtools detected in the plugin checkout; the production result is the same.
Steps and results
The following results are the same for the published packages and the two source-built HEADs:
- Build:
bunx vite build. Expected: the server component's stylesheet is available as a browser-served asset (or inline CSS) and represented in the relevant asset collection. Actual: no notes CSS underdist/client, no notes CSS entry indist/client/.vite/manifest.json. With plain Vite's default SSR asset settings, this minimal repro emits no standalone CSS underdist/servereither. The CSS Module variant still embeds the hashed class string in the server output. - Production document:
bunx vite preview --host 127.0.0.1 --port 5200 --strictPort, then open/bin a fresh browser context. Expected: red notes. Actual: HTTP 200, raw SSR HTML contains#notes, but no stylesheet link or inline rule;getComputedStyle(document.querySelector('#notes')).colorisrgb(0, 0, 0). Boot makes zero/_serverrequests, so document adoption itself works. - Production client navigation: in another fresh browser context, open
/aand click Page B. Expected: red notes, with styles delivered before reveal if they were not already loaded. Actual: a successfulapplication/x-frame-streamresponse from/_server/data/getNotes-d166722econtainsstart,html,complete, but noassetsrecord /styles. The element appears with black text. There are no page/console errors in these production checks. - Dev: run
bunx vite --host 127.0.0.1 --port 5201 --strictPortand repeat both browser paths. Actual: both are red. The initial document inlines the notes stylesheet in a<style data-asset="…/src/notes.css" data-vite-dev-id="…">, even on page A. The subsequent frame response still has no style assets, but this case already has the CSS. This dev/production difference hides the problem during development.
The CSS Module variant also reproduces: replace the import with import css from './notes.module.css' and use class={css.notes}. Production SSR and frame HTML contain a hashed class, e.g. _notes_5xr5i_1, with no matching stylesheet; dev is styled.
Workaround verified on both versions
With the plain .css variant above, also add import './notes.css' to src/App.tsx. The build then emits a client CSS asset, its manifest entry has css, the SSR document links it, and both production browser paths compute rgb(255, 0, 0). Dev also stays styled. This workaround eagerly loads the server component's styles through a client-owned import.
Design and source observations
I read the plugin README sections for serverFunctions, start, start.css.filter, and virtual:solid-manifest, plus the server-components docs. I did not find a documented requirement to repeat a server component's CSS import in a client module. css.filter is documented as development-only, and virtual:solid-manifest exposes the client build manifest in production.
The frame streams RFC, “4. Fragment assets and styles” describes assets with styles and style-gated reveal. This transport is present: frame-sink.ts, lines 565–577 emits CSS entries from meta.preloads as assets.styles.
The collection boundary appears to be earlier:
- The compiler's module-level client transform, lines 570–573 rebuilds the module from its server-function references, dropping its original imports. Directly inspecting the transform of this repro yields only
createServerReference(...)and the exported proxy;./notesis gone. Removing server implementation imports is expected; this observation explains why its transitive stylesheet is absent from the client graph. - The plugin consumes that transform and records function metadata, while the production manifest loader reads the client build manifest. In this repro that manifest has no notes CSS to deliver.
- In contrast, dev CSS collection traverses the SSR graph, which matches the observed working dev documents.
These are collection/transform observations, rather than a claim that the frames consumer rejects a supplied stylesheet. Should server-component CSS reached only through this boundary be collected for production as well, or is there an intended authoring pattern that should be documented?
Related context: #428 is my earlier report about a duplicated server-functions client in dev with optimizeDeps.exclude; this repro uses no exclusions and produces valid component HTML. Existing #414/#415 concern dev manifest timing/cache, and #425 concerns CSS ordering; those do not cover this production omission.
- 主要語言
- TypeScript
- 星號
- 523
- 分支
- 74
- 平均合併
- 1 天 19 小時
- 30 天內合併 PR
- 54
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
solidjs/solid-vite-plugin 的其他 Issue
-
Vitest config is dropped when test.server.deps.external already lists solid-js可能已有人在做 @RaphaelFakhri 於 4 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 78/100
solidjs/solid-vite-plugin#454 ·
維護者通常 1 天內回覆
-
Test environment detection doesn't consider Vitest workspaces可能已有人在做 @carloitaben 於 62 天前認領。 未關閉1.x
難度 2/5 1-3 小時 新手友好度 78/100
solidjs/solid-vite-plugin#205 · 1 則留言 · 2 個 reaction ·
維護者通常 1 天內回覆
-
難度 5/5 一週以上 新手友好度 35/100
solidjs/solid-vite-plugin#328 ·
維護者通常 1 天內回覆
-
jsx: 'preserve' in optimizeDeps breaks dependency scan when .tsx files use `import.meta.glob`可能已有人在做 @brenelz 於 35 天前認領。 未關閉1.x
難度 3/5 1-2 天 新手友好度 72/100
solidjs/solid-vite-plugin#262 · 2 則留言 ·
維護者通常 1 天內回覆
-
Speed up vite-plugin-solid with vite hook filters可能已有人在做 @ChristophP 於 52 天前認領。 未關閉1.x
難度 3/5 1-2 天 新手友好度 65/100
solidjs/solid-vite-plugin#259 · 2 則留言 · 1 個 reaction ·
維護者通常 1 天內回覆
查看 solidjs/solid-vite-plugin 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 76/100
Nimblesite/SharpLsp#468 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 72/100
維護者通常 1 天內回覆
-
Bundled uv is never updated and trusts the compromised eMudhra certificates可能已有人在做 @FabienDanieau 今天認領。 未關閉bug
難度 2/5 1-3 小時 新手友好度 76/100
-
bg_wait's blocking mode (stopOnAttention: false) is under-documented and effectively undiscoverable未關閉
難度 2/5 1-3 小時 新手友好度 66/100
nicobailon/pi-subagents#3019 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 66/100
db-ux-design-system/core-web#8613 ·
維護者通常 1 天內回覆