Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

Define `__SOLID_SERVER_COMPONENTS__` at build time so libraries can drop server-component-only client code

Offen
  • Stimmt etwas nicht?
#396 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
55/100
Issue-Typ
Feature
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
rollup, typescript, vite
Bereich
build-system

Rechercherichtung

Start in the main plugin's config() hook, next to the existing optimizeDeps.rolldownOptions.transform.jsx, and trace how serverFunctions.components and user define values are resolved. Add the constant in both requested define locations and cover the true, false, and user-provided cases; update the RFC 11 integration surface and server-components skill docs. Done when the checklist is covered and plugin tests pass.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Problem

@solidjs/router ships a client fallback for server-component forms. These forms arrive as URLs in the HTML with no client reference. When no action() handler is installed, the router intercepts POSTs under actionBase and lazily imports its action layer.

Only server-component apps need this, but every router app pays for it. In a minimal router app with no server functions (Vite 8, gzip):

  • about 0.85 KB eager (up to 1.4 KB when it's the app's only dynamic import);
  • a 16.8 KB lazy chain: the serverForms chunk (8.6 KB) plus the decode chunk (7.0 KB) and a server chunk (1.2 KB) behind it.

The router's flat build inlines all of it eagerly (about 8 KB).

Proposal

The plugin defines a global constant __SOLID_SERVER_COMPONENTS__. Core owns and documents the name, with the meaning "server components are enabled for this build".

  • Value: true when serverFunctions.components is truthy (including 'external'), otherwise false. It must always be defined: if it's left undefined, nothing can be removed.
  • Set it in both top-level define (build, and dev source via /@vite/env) and optimizeDeps.rolldownOptions.transform.define (dev pre-bundled dependencies; the optimizer ignores top-level define).
  • Respect a user-provided define[__SOLID_SERVER_COMPONENTS__].
  • Applying it to all environments is fine; it's harmless on the server.

Why a define

Whether a check folds away depends on the form:

Form Rollup Rolldown 1.2.6 esbuild
Imported, never-written let flag folds doesn't fold doesn't fold
Literal define folds folds folds

Cost

Zero for apps. One config entry in the plugin.

Router follow-up

declare const __SOLID_SERVER_COMPONENTS__: boolean | undefined;
if (typeof __SOLID_SERVER_COMPONENTS__ !== "undefined" && __SOLID_SERVER_COMPONENTS__) {
  /* intercept */ import("./serverForms.js")...
}
Bundler, solid entry today, KB gz eager / lazy with false
Rolldown 18.84 / 16.22 17.97 / 0
Rollup 19.74 / 15.22 18.94 / 0
esbuild 22.62 eager, serverForms lazy 20.95, serverForms gone
  • With true, output matches today and serverForms stays lazy, so server-component apps without action() still don't pay for it eagerly.
  • In the flat build, false saves about 7–8 KB eager.
  • The router's own build (tsc + Rollup) keeps the guard; no config change is needed.
  • Without the plugin, the fallback is off at runtime and the bytes are the same as today. Server-component setups without the plugin define the constant themselves, as documented in core.

Alternatives considered

  • configureClient setup modules: too much wiring through start mode.
  • A runtime flag in server-functions/frames: doesn't fold under Rolldown or esbuild (measured above).
  • The router installing the fallback from serverRouteComponent/action: leaves a coverage gap, because forms can arrive with neither present.
  • Asking Rolldown upstream to fold imported constants: out of our control.

Implementation sketch

This goes in the main plugin's config() hook, next to the existing optimizeDeps.rolldownOptions.transform.jsx, using the serverFunctions.components value resolved in solidPlugin().

const SC_KEY = "__SOLID_SERVER_COMPONENTS__";
// inside config():
const scDefine = { [SC_KEY]: userConfig.define?.[SC_KEY] ?? JSON.stringify(serverComponents) };
return {
  define: scDefine,
  optimizeDeps: {
    // ...existing
    rolldownOptions: { transform: { jsx: { runtime: "classic" }, define: scDefine }, plugins: [/* existing */] }
  }
};

Checklist

  • Plugin: define plus optimizeDeps.rolldownOptions.transform.define; respect the user's value.
  • Core docs: RFC 11 integration surface and the server-components skill (cross-link).
  • Router: wrapped guard; vitest define true plus an off-path test; changeset.
Vorherrschende Sprache
TypeScript
Sterne
522
Forks
72
Ø Merge
1 T. 8 Std.
Gemergte PRs (30 T.)
29

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus solidjs/solid-vite-plugin

Alle Issues in solidjs/solid-vite-plugin

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.