Forward pressed while a Back navigation is still loading is dropped; the URL and the rendered route get out of sync

Geschlossen
  • Stimmt etwas nicht?
#687 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@sean0407 arbeitet bereits daran.

Seit 20.10.2026.

  • #689 von @sean0407 — offen

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
54/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
javascript, typescript
Bereich
frontend

Rechercherichtung

Start in src/routing.ts at the transition() comparison around lines 487–488, then inspect navigateFromRoute() around lines 613–615, which makes a similar comparison. Reproduce Back → Forward while the /slow resource is pending using the inline Vite example and compare the proposed pending-target check with the route-click path. Done means browser history and the rendered route plus useLocation() stay in sync for both cases; run the router test suite after changes.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

1.x
Describe the bug

Press Back, then press Forward before the route that Back entered has finished loading. The Forward is dropped:

  • the address bar shows the Forward location;
  • once the pending data resolves, the router commits and renders the Back location;
  • useLocation() reports the Back location.

The app stays out of sync with the URL until the user navigates to another route or reloads. A link to the rendered route does nothing, because the router believes it is already there.

The cause is that transition() returns early when the target equals reference():

https://github.com/solidjs/solid-router/blob/d0379e737c0feb9daa1d67cb94d132fa77638634/src/routing.ts#L487-L488

While the Back transition is pending, reference() read outside it still holds the committed location, which is the page we were on before Back. Forward targets that same location, so transition() treats it as a no-op, and the pending Back transition then commits.

We hit this in a production app on pages whose data loads on entry.

Your Example Website or App

The repro is inline below, with no StackBlitz link. It is Vite + vite-plugin-solid, and its only runtime dependencies are solid-js 1.9.15 and @solidjs/router (0.15.4 or 1.0.0).

// src/main.jsx
import { render } from "solid-js/web";
import { createResource, Suspense } from "solid-js";
import { Router, Route, A, useLocation } from "@solidjs/router";

const wait = (ms) => new Promise((resolve) => setTimeout(resolve, ms));

function Home() {
  return <h1>Home</h1>;
}

// Its data takes 500 ms, so entering /slow (also via Back) is a pending transition for 500 ms
function Slow() {
  const [data] = createResource(() => wait(500).then(() => "loaded"));
  return <h1>Slow ({data()})</h1>;
}

function Fast() {
  return <h1>Fast</h1>;
}

render(
  () => (
    <Router
      root={(props) => (
        <>
          <nav>
            <A href="/">home</A> | <A href="/slow">slow</A> | <A href="/fast">fast</A>
          </nav>
          <p id="loc">useLocation: {useLocation().pathname}</p>
          <Suspense>{props.children}</Suspense>
        </>
      )}
    >
      <Route path="/" component={Home} />
      <Route path="/slow" component={Slow} />
      <Route path="/fast" component={Fast} />
    </Router>
  ),
  document.getElementById("app")
);
Steps to Reproduce the Bug or Issue
  1. Open /, click slow, and wait until the page shows "Slow (loaded)".
  2. Click fast.
  3. Press browser Back, then Forward before /slow's 500 ms resource resolves.
Expected behavior

The page shows "Fast" at /fast.

Actual behavior:

  • the address bar shows /fast;
  • the page shows "Slow (loaded)";
  • useLocation().pathname is /slow.

Clicking slow then changes nothing. Clicking fast recovers.

I measured this with Playwright, pressing Forward right after Back:

  • Chromium 145: out of sync in 10 of 10 runs on 0.15.4, and in 10 of 10 on 1.0.0;
  • Firefox 146 and WebKit 26: out of sync in 5 of 5 runs each, on 1.0.0.

With Forward 1 s after Back, after the resource had resolved, every run was correct.

Platform
  • OS: Windows 11
  • Browser: Chromium 145, Firefox 146, WebKit 26 (Playwright builds)
  • Version: @solidjs/router 0.15.4 and 1.0.0, solid-js 1.9.15. main has the same code. 2.0.0-next is a different implementation, and I did not test it.
Additional context

A possible fix is to compare against the pending target when there is one:

const current = lastTransitionTarget || { value: reference(), state: state() };
if (newTarget.value === current.value && newTarget.state === current.state) return;

With this change applied to the built bundle, Back → Forward ends on "Fast" in 10 of 10 runs on 0.15.4 and on 1.0.0. I have not run the router's test suite against it.

navigateFromRoute makes the same comparison with reference() (L613-L615). Clicking slow and then fast at once stays on /slow in 10 of 10 runs. URL and page agree there, but the second click is lost. The change above does not cover that path.

Vorherrschende Sprache
TypeScript
Sterne
1.3k
Forks
185
Ø Merge
1 T. 40 Min.
Gemergte PRs (30 T.)
42

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus solidjs/solid-router

Alle Issues in solidjs/solid-router

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.