Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Forward pressed while a Back navigation is still loading is dropped; the URL and the rendered route get out of sync

オープン
  • 何か問題がありますか？
#687 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
1〜2日
初心者へのやさしさ
54/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
javascript, typescript
領域
frontend

調査の方向性

Start in src/routing.ts at the transition() comparison around lines 487–488, then inspect navigateFromRoute() around lines 613–615, which makes a similar comparison. Reproduce Back → Forward while the /slow resource is pending using the inline Vite example and compare the proposed pending-target check with the route-click path. Done means browser history and the rendered route plus useLocation() stay in sync for both cases; run the router test suite after changes.

索引モデルが issue の本文から書いたものです。

説明

Describe the bug

Press Back, then press Forward before the route that Back entered has finished loading. The Forward is dropped:

  • the address bar shows the Forward location;
  • once the pending data resolves, the router commits and renders the Back location;
  • useLocation() reports the Back location.

The app stays out of sync with the URL until the user navigates to another route or reloads. A link to the rendered route does nothing, because the router believes it is already there.

The cause is that transition() returns early when the target equals reference():

https://github.com/solidjs/solid-router/blob/d0379e737c0feb9daa1d67cb94d132fa77638634/src/routing.ts#L487-L488

While the Back transition is pending, reference() read outside it still holds the committed location, which is the page we were on before Back. Forward targets that same location, so transition() treats it as a no-op, and the pending Back transition then commits.

We hit this in a production app on pages whose data loads on entry.

Your Example Website or App

The repro is inline below, with no StackBlitz link. It is Vite + vite-plugin-solid, and its only runtime dependencies are solid-js 1.9.15 and @solidjs/router (0.15.4 or 1.0.0).

// src/main.jsx
import { render } from "solid-js/web";
import { createResource, Suspense } from "solid-js";
import { Router, Route, A, useLocation } from "@solidjs/router";

const wait = (ms) => new Promise((resolve) => setTimeout(resolve, ms));

function Home() {
  return <h1>Home</h1>;
}

// Its data takes 500 ms, so entering /slow (also via Back) is a pending transition for 500 ms
function Slow() {
  const [data] = createResource(() => wait(500).then(() => "loaded"));
  return <h1>Slow ({data()})</h1>;
}

function Fast() {
  return <h1>Fast</h1>;
}

render(
  () => (
    <Router
      root={(props) => (
        <>
          <nav>
            <A href="/">home</A> | <A href="/slow">slow</A> | <A href="/fast">fast</A>
          </nav>
          <p id="loc">useLocation: {useLocation().pathname}</p>
          <Suspense>{props.children}</Suspense>
        </>
      )}
    >
      <Route path="/" component={Home} />
      <Route path="/slow" component={Slow} />
      <Route path="/fast" component={Fast} />
    </Router>
  ),
  document.getElementById("app")
);
Steps to Reproduce the Bug or Issue
  1. Open /, click slow, and wait until the page shows "Slow (loaded)".
  2. Click fast.
  3. Press browser Back, then Forward before /slow's 500 ms resource resolves.
Expected behavior

The page shows "Fast" at /fast.

Actual behavior:

  • the address bar shows /fast;
  • the page shows "Slow (loaded)";
  • useLocation().pathname is /slow.

Clicking slow then changes nothing. Clicking fast recovers.

I measured this with Playwright, pressing Forward right after Back:

  • Chromium 145: out of sync in 10 of 10 runs on 0.15.4, and in 10 of 10 on 1.0.0;
  • Firefox 146 and WebKit 26: out of sync in 5 of 5 runs each, on 1.0.0.

With Forward 1 s after Back, after the resource had resolved, every run was correct.

Platform
  • OS: Windows 11
  • Browser: Chromium 145, Firefox 146, WebKit 26 (Playwright builds)
  • Version: @solidjs/router 0.15.4 and 1.0.0, solid-js 1.9.15. main has the same code. 2.0.0-next is a different implementation, and I did not test it.
Additional context

A possible fix is to compare against the pending target when there is one:

const current = lastTransitionTarget || { value: reference(), state: state() };
if (newTarget.value === current.value && newTarget.state === current.state) return;

With this change applied to the built bundle, Back → Forward ends on "Fast" in 10 of 10 runs on 0.15.4 and on 1.0.0. I have not run the router's test suite against it.

navigateFromRoute makes the same comparison with reference() (L613-L615). Clicking slow and then fast at once stays on /slow in 10 of 10 runs. URL and page agree there, but the second click is lost. The change above does not cover that path.

主要言語
TypeScript
スター
1.3k
フォーク
183
平均マージ
14時間 35分
マージ済み PR（30日）
52

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

solidjs/solid-router のほかの issue

solidjs/solid-router の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。