platform: sslmode=verify-full in a database URL fails as a generic configuration error

Offen
#2,746 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
38/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
postgresql, rust
Bereich
backend, database

Rechercherichtung

Start in crates/registry-messaging/src/store.rs at PgConfig::from_str(url).map_err(|_| StoreError::Configuration) and confirm tokio-postgres 0.7.18's accepted sslmode values in Config::from_str. Before writing anything, check whether each runtime's TLS setup verifies both chain and host name, since that decides whether verify-ca/verify-full can be accepted or must be refused with a named error. The same parser appears in BReg, Casework, Scheduling, Document Store, the Adapter facade and job host; docs live in operate/breg.mdx and operate/coordinator.mdx. Done means one rule applied everywhere plus a verify-full test per product.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area:platform bug

Problem

A database URL with sslmode=verify-full fails as a generic configuration error. verify-full is the value the PostgreSQL documentation recommends, so operators will write it.

Observed with Messaging during the Stage 0 adopter run for #2745: messagingctl plan reported error[database.unavailable] ... configuration is invalid against a private CA. The same URL with sslmode=require and database.trustedRootCertificateRef worked.

Cause

tokio-postgres 0.7.18 accepts only disable, prefer and require for sslmode (Config::from_str). Any other value fails to parse, and the product maps the parse failure to its generic configuration error. In Messaging that is crates/registry-messaging/src/store.rs, PgConfig::from_str(url).map_err(|_| StoreError::Configuration).

The same parser reads the database URL in BReg, Casework, Scheduling, Document Store, the Adapter facade and the Adapter job host.

The runtimes already force TLS and verify the server certificate against the configured trust roots, whatever sslmode says.

Docs disagree

  • operate/breg.mdx says the URL needs no sslmode parameter, because the runtime requires TLS itself.
  • operate/coordinator.mdx says to use sslmode=require.
  • The other operate pages do not say which values they accept.

Proposal

  1. Pick one rule for every product. Either accept verify-ca and verify-full, since the runtime already verifies the certificate, or refuse them with an error that names sslmode and the accepted values. Accepting them is the simpler adopter path, but only if the runtime's verification is at least what verify-full promises (chain and host name). Check that before choosing.
  2. Put one sentence about sslmode on every operate page that takes a database URL, using the same wording.

Both changes need a test per product that a verify-full URL gives the chosen result.

Vorherrschende Sprache
Rust
Sterne
2
Forks
0
Ø Merge
9 Std. 48 Min.
Gemergte PRs (30 T.)
151

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus registrystack/registry-stack

Alle Issues in registrystack/registry-stack

Ähnliche Issues

Weitere Issues zu Rust

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.