platform: sslmode=verify-full in a database URL fails as a generic configuration error

Abierto
#2,746 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
38/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
postgresql, rust
Área
backend, database

Línea de trabajo

Start in crates/registry-messaging/src/store.rs at PgConfig::from_str(url).map_err(|_| StoreError::Configuration) and confirm tokio-postgres 0.7.18's accepted sslmode values in Config::from_str. Before writing anything, check whether each runtime's TLS setup verifies both chain and host name, since that decides whether verify-ca/verify-full can be accepted or must be refused with a named error. The same parser appears in BReg, Casework, Scheduling, Document Store, the Adapter facade and job host; docs live in operate/breg.mdx and operate/coordinator.mdx. Done means one rule applied everywhere plus a verify-full test per product.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:platform bug

Problem

A database URL with sslmode=verify-full fails as a generic configuration error. verify-full is the value the PostgreSQL documentation recommends, so operators will write it.

Observed with Messaging during the Stage 0 adopter run for #2745: messagingctl plan reported error[database.unavailable] ... configuration is invalid against a private CA. The same URL with sslmode=require and database.trustedRootCertificateRef worked.

Cause

tokio-postgres 0.7.18 accepts only disable, prefer and require for sslmode (Config::from_str). Any other value fails to parse, and the product maps the parse failure to its generic configuration error. In Messaging that is crates/registry-messaging/src/store.rs, PgConfig::from_str(url).map_err(|_| StoreError::Configuration).

The same parser reads the database URL in BReg, Casework, Scheduling, Document Store, the Adapter facade and the Adapter job host.

The runtimes already force TLS and verify the server certificate against the configured trust roots, whatever sslmode says.

Docs disagree

  • operate/breg.mdx says the URL needs no sslmode parameter, because the runtime requires TLS itself.
  • operate/coordinator.mdx says to use sslmode=require.
  • The other operate pages do not say which values they accept.

Proposal

  1. Pick one rule for every product. Either accept verify-ca and verify-full, since the runtime already verifies the certificate, or refuse them with an error that names sslmode and the accepted values. Accepting them is the simpler adopter path, but only if the runtime's verification is at least what verify-full promises (chain and host name). Check that before choosing.
  2. Put one sentence about sslmode on every operate page that takes a database URL, using the same wording.

Both changes need a test per product that a verify-full URL gives the chosen result.

Lenguaje dominante
Rust
Estrellas
2
Forks
0
Merge medio
9 h 48 min
PR fusionados (30 d)
151

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de registrystack/registry-stack

Todos los issues de registrystack/registry-stack

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.