breg: serve each profile's writable inputs in the Action metadata
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 54/100
- Issue-Typ
- Feature
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- rust
- Bereich
- api, backend-api-design
Rechercherichtung
Start with the proposals.actions[] inventory in crates/registry-breg/src/api/mod.rs:761 and the per-profile metadata entry in crates/registry-breg/src/artifacts.rs:1304; trace how compiled permissions supply readable inputs and writable inputs. Then inspect the Rust client metadata, crates/registry-breg-client-node/client.d.ts, the Python binding, and the Proposals docs and metadata schema. Done means the acceptance cases pass for explicit, default, and empty writable input lists, and all three clients expose the field with type tests.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Problem
A Proposal grant can restrict a profile to a list of writableInputs. The engine compiles the list and enforces it: an Edit, Revise, Rebase or Start that changes any other input is refused. The metadata never serves the list. A client cannot tell a fixed input from an editable one, so a form lets people change fields the server will then refuse. The person finds out only after submitting.
Evidence
All line numbers are on origin/main at 36d25ef652.
crates/registry-breg/src/contract.rs:715:writable_inputs: Option<UniqueSet<String>>on the grant source. Absent means every declared input is writable.crates/registry-breg/src/model.rs:578: the compiledwritable_inputs: Option<BTreeSet<String>>onCompiledProposalPermission.crates/registry-breg/src/immediate_actions.rs:2912to:2939: package validation of the list.crates/registry-breg/src/mutation/proposal.rs:130to:156(validate_input_write_authority) refuses a value outside the list. It is called at:1180(Start) and:1489.crates/registry-breg/src/mutation/proposal.rs:590: the list is part of the request digest contract, so it is already treated as part of the public response contract.crates/registry-breg/src/api/mod.rs:761to:780: theproposals.actions[]inventory servesactionId,accessProfile,operations,readableInputsandreadableContextFields. It has no writable member.crates/registry-breg-client-node/client.d.ts:497to:503(BRegProposalActionDescriptor) andcrates/registry-breg-client/src/metadata.rs:966to:981carryreadableInputsonly. The Python binding follows the Rust client (crates/registry-breg-client-py/src/lib.rs:1527).- Documented behaviour:
docs/site/src/content/docs/configure/breg-proposals.mdx:133to:172says a grant withoutwritableInputsleaves every input writable.
Proposed change
- Add
writableInputsto eachproposals.actions[]entry, for profiles whose operations include Start, Edit, Revise or Rebase. Absent grant list serves the full set of declared inputs, so the member is always present and a client does not need to know the default rule. Serve an empty list for profiles that cannot write. - Also serve it in the per-profile Action description (
public_action_metadata_entry,crates/registry-breg/src/artifacts.rs:1304) where a profile can start the Action. - Add the member to the Rust client, the Node client types and the Python binding. This is an additive response member, so it relies on the client tolerance work in #1945.
- Update the Proposals configuration page and the metadata schema.
Acceptance
- A test shows a grant with
writableInputs: [a]serves["a"], and a grant without the key serves every declared input. - A test shows a reader serves an empty list.
- The Rust, Node and Python clients expose the member, with type tests.
- A client form built from the metadata cannot offer an input that the server refuses.
- Vorherrschende Sprache
- Rust
- Sterne
- 2
- Forks
- 0
- Ø Merge
- 9 Std. 48 Min.
- Gemergte PRs (30 T.)
- 151
Entwicklungsumgebung
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus registrystack/registry-stack
-
area:breg enhancement
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
registrystack/registry-stack#2765 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
registrystack/registry-stack#2761 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
registrystack/registry-stack#2743 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
registrystack/registry-stack#2706 ·
Maintainer antworten meist innerhalb von 1 Tag
-
macOS contributor gates: Messaging config tests fail under the symlinked macOS temporary directoryOffen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 83/100
registrystack/registry-stack#2704 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in registrystack/registry-stack
Ähnliche Issues
-
[Bug] 建议把黑白主题设置同步到启动页面Offenbug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
AstrBotDevs/AstrBot-desktop#197 ·
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 75/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 82/100
stackabletech/airflow-operator#898 ·
Maintainer antworten meist innerhalb von 1 Tag
-
2 advisory ignore entries no longer match anything (`bytes`, `time` already patched in `Cargo.lock`)Evtl. vergeben @zyl71 hat das heute übernommen. Offen
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 88/100