breg: serve each profile's writable inputs in the Action metadata
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 54/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- rust
- Área
- api, backend-api-design
Línea de trabajo
Start with the proposals.actions[] inventory in crates/registry-breg/src/api/mod.rs:761 and the per-profile metadata entry in crates/registry-breg/src/artifacts.rs:1304; trace how compiled permissions supply readable inputs and writable inputs. Then inspect the Rust client metadata, crates/registry-breg-client-node/client.d.ts, the Python binding, and the Proposals docs and metadata schema. Done means the acceptance cases pass for explicit, default, and empty writable input lists, and all three clients expose the field with type tests.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Problem
A Proposal grant can restrict a profile to a list of writableInputs. The engine compiles the list and enforces it: an Edit, Revise, Rebase or Start that changes any other input is refused. The metadata never serves the list. A client cannot tell a fixed input from an editable one, so a form lets people change fields the server will then refuse. The person finds out only after submitting.
Evidence
All line numbers are on origin/main at 36d25ef652.
crates/registry-breg/src/contract.rs:715:writable_inputs: Option<UniqueSet<String>>on the grant source. Absent means every declared input is writable.crates/registry-breg/src/model.rs:578: the compiledwritable_inputs: Option<BTreeSet<String>>onCompiledProposalPermission.crates/registry-breg/src/immediate_actions.rs:2912to:2939: package validation of the list.crates/registry-breg/src/mutation/proposal.rs:130to:156(validate_input_write_authority) refuses a value outside the list. It is called at:1180(Start) and:1489.crates/registry-breg/src/mutation/proposal.rs:590: the list is part of the request digest contract, so it is already treated as part of the public response contract.crates/registry-breg/src/api/mod.rs:761to:780: theproposals.actions[]inventory servesactionId,accessProfile,operations,readableInputsandreadableContextFields. It has no writable member.crates/registry-breg-client-node/client.d.ts:497to:503(BRegProposalActionDescriptor) andcrates/registry-breg-client/src/metadata.rs:966to:981carryreadableInputsonly. The Python binding follows the Rust client (crates/registry-breg-client-py/src/lib.rs:1527).- Documented behaviour:
docs/site/src/content/docs/configure/breg-proposals.mdx:133to:172says a grant withoutwritableInputsleaves every input writable.
Proposed change
- Add
writableInputsto eachproposals.actions[]entry, for profiles whose operations include Start, Edit, Revise or Rebase. Absent grant list serves the full set of declared inputs, so the member is always present and a client does not need to know the default rule. Serve an empty list for profiles that cannot write. - Also serve it in the per-profile Action description (
public_action_metadata_entry,crates/registry-breg/src/artifacts.rs:1304) where a profile can start the Action. - Add the member to the Rust client, the Node client types and the Python binding. This is an additive response member, so it relies on the client tolerance work in #1945.
- Update the Proposals configuration page and the metadata schema.
Acceptance
- A test shows a grant with
writableInputs: [a]serves["a"], and a grant without the key serves every declared input. - A test shows a reader serves an empty list.
- The Rust, Node and Python clients expose the member, with type tests.
- A client form built from the metadata cannot offer an input that the server refuses.
- Lenguaje dominante
- Rust
- Estrellas
- 2
- Forks
- 0
- Merge medio
- 9 h 48 min
- PR fusionados (30 d)
- 151
Preparar el entorno
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de registrystack/registry-stack
-
area:breg enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
registrystack/registry-stack#2765 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
registrystack/registry-stack#2761 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
registrystack/registry-stack#2743 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
registrystack/registry-stack#2706 ·
Los mantenedores suelen responder en 1 día
-
macOS contributor gates: Messaging config tests fail under the symlinked macOS temporary directoryAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 83/100
registrystack/registry-stack#2704 ·
Los mantenedores suelen responder en 1 día
Todos los issues de registrystack/registry-stack
Issues similares
-
[Bug] 建议把黑白主题设置同步到启动页面Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
AstrBotDevs/AstrBot-desktop#197 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 75/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 82/100
stackabletech/airflow-operator#898 ·
Los mantenedores suelen responder en 1 día
-
2 advisory ignore entries no longer match anything (`bytes`, `time` already patched in `Cargo.lock`)Posiblemente ocupada @zyl71 la tomó hoy. Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100