Remove Redundant Type Hierarchy
Maintainer antworten meist innerhalb von 1 Tag
Bewertung
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Anfängerfreundlichkeit
- 66/100
- Issue-Typ
- Refactoring
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- typescript, vscode
- Bereich
- tooling
Rechercherichtung
Start in package.json and find the command IDs and menu contributions for the custom type hierarchy, then grep those IDs across the extension. Read typeHierarchyTree.ts and references-view.d.ts to see what can be deleted, and check the command implementations registered elsewhere. Done means the duplicate "Show Type Hierarchy" entry is gone, the custom commands and UI code are removed, and the extension builds and tests pass.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Describe the bug
Currently, when you right click a class name, there are two context menu entries called "Show Type Hierarchy".
One is contributed by us (vscode-java) and one is a default one provided by VS Code.
We should remove the entry provided by us, along with all the associated UI code, since the default type hierarchy UI provided by VS Code is sufficient, and removing code with reduce the complexity of this project. VS Code provides this UI automatically, since jdtls advertises it supports type hierarchy. The other entry exists because we implemented type hierarchy support before it was added into the LSP specification.
There is one minor difference between our custom type hierarchy UI and the default UI: we provide a "Class Hierarchy" view that shows both super classes and sub classes at the same time. However, after talking this through with Rob, I don't think it's worth saving this UI, since then there would be two different ways to access the same information, which would be confusing to end users.
Here's a list of things we'll need to remove: (hopefully complete but there might be other things as well):
- The UI itself, i.e.
typeHierarchyTree.ts - The typings we have for interacting with VS Code's references view API (
references-view.d.ts) - The commands to open the type hierarchy view (these are registered in package.json and implemented throughout the codebase; grepping for the id listed in the package.json should find the implementations)
- The registration of various commands (also in the package.json)
- There's separate "Subtype hierarchy" and "Supertype hierarchy" commands that are referenced in code, but only appear in the command palette and currently don't seem to function. These should be removed
See https://github.com/redhat-developer/vscode-java/pull/2376 for some more context
To Reproduce
Steps to reproduce the behaviour:
- Make a type that inherits from a few other types:
public class B extends A implements Serializable {
}
- Right click on the type name (in this case
B). - There are two "Show Type Hierarchy"
Expected behaviour
There should instead be one "Show Type Hierarchy" entry
Environment
- Operating System: Linux (but it's not Linux specific)
- JDK version: 25
- Visual Studio Code version: 1.143.1
- Java extension version: 1.59.0
Additional Information
- Vorherrschende Sprache
- TypeScript
- Sterne
- 2.3k
- Forks
- 549
- Ø Merge
- 4 T. 16 Std.
- Gemergte PRs (30 T.)
- 20
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus redhat-developer/vscode-java
-
bug
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 45/100
redhat-developer/vscode-java#4564 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 55/100
redhat-developer/vscode-java#4550 · 1 Kommentar · 1 Reaktion ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 48/100
redhat-developer/vscode-java#4537 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug need info
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 35/100
redhat-developer/vscode-java#4520 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 25/100
redhat-developer/vscode-java#4517 · 2 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in redhat-developer/vscode-java
Ähnliche Issues
-
area:cli bug P4
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
Maintainer antworten meist innerhalb von 1 Tag
-
bug from-studio
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
esengine/DeepSeek-Reasonix#14868 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
Maintainer antworten meist innerhalb von 1 Tag
-
bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
loopbackio/loopback-next#11878 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
bug 🐛
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
comunica/comunica#1925 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag