Remove Redundant Type Hierarchy

Fermée
  • Quelque chose ne va pas ?
#4,560 0 commentaires 0 réactions 1 personne assignée Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

@MeherSru y travaille déjà.

Depuis le 28/10/2026.

  • #4565 par @MeherSru — ouverte

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
66/100
Type d'issue
Refactorisation
Clarté
Plutôt claire
Activité
Active
Stack technique
typescript, vscode
Domaine
tooling

Piste de recherche

Start in package.json and find the command IDs and menu contributions for the custom type hierarchy, then grep those IDs across the extension. Read typeHierarchyTree.ts and references-view.d.ts to see what can be deleted, and check the command implementations registered elsewhere. Done means the duplicate "Show Type Hierarchy" entry is gone, the custom commands and UI code are removed, and the extension builds and tests pass.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug

Describe the bug
Currently, when you right click a class name, there are two context menu entries called "Show Type Hierarchy".

One is contributed by us (vscode-java) and one is a default one provided by VS Code.

We should remove the entry provided by us, along with all the associated UI code, since the default type hierarchy UI provided by VS Code is sufficient, and removing code with reduce the complexity of this project. VS Code provides this UI automatically, since jdtls advertises it supports type hierarchy. The other entry exists because we implemented type hierarchy support before it was added into the LSP specification.

There is one minor difference between our custom type hierarchy UI and the default UI: we provide a "Class Hierarchy" view that shows both super classes and sub classes at the same time. However, after talking this through with Rob, I don't think it's worth saving this UI, since then there would be two different ways to access the same information, which would be confusing to end users.

Here's a list of things we'll need to remove: (hopefully complete but there might be other things as well):

  1. The UI itself, i.e. typeHierarchyTree.ts
  2. The typings we have for interacting with VS Code's references view API (references-view.d.ts)
  3. The commands to open the type hierarchy view (these are registered in package.json and implemented throughout the codebase; grepping for the id listed in the package.json should find the implementations)
  4. The registration of various commands (also in the package.json)
  5. There's separate "Subtype hierarchy" and "Supertype hierarchy" commands that are referenced in code, but only appear in the command palette and currently don't seem to function. These should be removed

See https://github.com/redhat-developer/vscode-java/pull/2376 for some more context

To Reproduce
Steps to reproduce the behaviour:

  1. Make a type that inherits from a few other types:
public class B extends A implements Serializable {

}
  1. Right click on the type name (in this case B).
  2. There are two "Show Type Hierarchy"

Expected behaviour
There should instead be one "Show Type Hierarchy" entry

Environment

  • Operating System: Linux (but it's not Linux specific)
  • JDK version: 25
  • Visual Studio Code version: 1.143.1
  • Java extension version: 1.59.0

Additional Information

Langage dominant
TypeScript
Étoiles
2.3k
Forks
549
Merge moyen
4 j 16 h
PR mergées (30 j)
20

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de redhat-developer/vscode-java

Toutes les issues de redhat-developer/vscode-java

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.