[RISC-V64/Linux] mprotect(addr, SIZE_MAX, ...) returns success

Offen
#1,685 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
60/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
linux, python

Rechercherichtung

The bug is in the POSIX mprotect handler at qiling/os/posix/syscall/mman.py around lines 65-73, which calls ql.mem.protect(start, mlen, prot) and returns success even when the range is rejected. Start by reading that handler and the memory protect call it depends on, then run the probe from the issue with SIZE_MAX as the length. Done means the SIZE_MAX request returns -1 with errno ENOMEM on RV64 Linux, while the one-page control still returns 0.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Describe the bug

On an RV64 Linux guest, Qiling returns success for mprotect() when the requested length is SIZE_MAX and the start address is a valid mapped page. Linux returns ENOMEM because the range extends beyond the guest address space. A normal one-page protection change succeeds as a control.

Sample Code
#include <errno.h>
#include <stdint.h>
#include <stdio.h>
#include <sys/mman.h>
#include <sys/syscall.h>
#include <unistd.h>

int main(void)
{
    void *page = mmap(NULL, 4096, PROT_READ | PROT_WRITE,
                      MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
    if (page == MAP_FAILED)
        return 2;

    errno = 0;
    long invalid = syscall(SYS_mprotect, page, (size_t)-1, PROT_READ);
    int invalid_errno = errno;

    void *control_page = mmap(NULL, 4096, PROT_READ | PROT_WRITE,
                              MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
    if (control_page == MAP_FAILED)
        return 3;
    errno = 0;
    long control = syscall(SYS_mprotect, control_page, 4096, PROT_READ);
    int control_errno = errno;

    printf("invalid=%ld errno=%d control=%ld control_errno=%d\n",
           invalid, invalid_errno, control, control_errno);
    return 0;
}

Compile this as a static RV64 Linux guest and run it with Qiling 1.4.11 and the dev branch:

riscv64-linux-gnu-gcc -static -O2 -Wall -Wextra mprotect_probe.c -o probe.elf
mkdir -p rootfs
cp probe.elf rootfs/probe.elf
python3 -c 'from qiling import Qiling; Qiling(["./rootfs/probe.elf"], "./rootfs").run()'

Qiling returns success for the SIZE_MAX request. Native Linux and QEMU RV64 return -1 with errno=ENOMEM; all tested runtimes return 0 for the one-page control.

Expected behavior

The overflowing range should fail with ENOMEM. The report covers the return value for a page-aligned mapped start and SIZE_MAX length; it does not claim the state of page permissions after the rejected request.

Additional context

Reproduced with Qiling v1.4.11 on RV64 Linux. Current dev commit 23ad4fd369a360ad7992d90cb7577f0241061c2b still calls ql.mem.protect(start, mlen, prot) and returns success if that call silently rejects the invalid range; see mman.py. The current dev source was checked statically, not dynamically run for this report.

Vorherrschende Sprache
Python
Sterne
6.2k
Forks
806
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Entwicklungsumgebung

  • Enthält ein Dockerfile oder eine Docker-Compose-Datei
  • Hat eine Pull-Request-Vorlage
  • Kein Beitragsleitfaden

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus qilingframework/qiling

Alle Issues in qilingframework/qiling

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.