[RISC-V64/Linux] mprotect(addr, SIZE_MAX, ...) returns success

Abierto
#1,685 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
60/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
linux, python

Línea de trabajo

The bug is in the POSIX mprotect handler at qiling/os/posix/syscall/mman.py around lines 65-73, which calls ql.mem.protect(start, mlen, prot) and returns success even when the range is rejected. Start by reading that handler and the memory protect call it depends on, then run the probe from the issue with SIZE_MAX as the length. Done means the SIZE_MAX request returns -1 with errno ENOMEM on RV64 Linux, while the one-page control still returns 0.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Describe the bug

On an RV64 Linux guest, Qiling returns success for mprotect() when the requested length is SIZE_MAX and the start address is a valid mapped page. Linux returns ENOMEM because the range extends beyond the guest address space. A normal one-page protection change succeeds as a control.

Sample Code
#include <errno.h>
#include <stdint.h>
#include <stdio.h>
#include <sys/mman.h>
#include <sys/syscall.h>
#include <unistd.h>

int main(void)
{
    void *page = mmap(NULL, 4096, PROT_READ | PROT_WRITE,
                      MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
    if (page == MAP_FAILED)
        return 2;

    errno = 0;
    long invalid = syscall(SYS_mprotect, page, (size_t)-1, PROT_READ);
    int invalid_errno = errno;

    void *control_page = mmap(NULL, 4096, PROT_READ | PROT_WRITE,
                              MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
    if (control_page == MAP_FAILED)
        return 3;
    errno = 0;
    long control = syscall(SYS_mprotect, control_page, 4096, PROT_READ);
    int control_errno = errno;

    printf("invalid=%ld errno=%d control=%ld control_errno=%d\n",
           invalid, invalid_errno, control, control_errno);
    return 0;
}

Compile this as a static RV64 Linux guest and run it with Qiling 1.4.11 and the dev branch:

riscv64-linux-gnu-gcc -static -O2 -Wall -Wextra mprotect_probe.c -o probe.elf
mkdir -p rootfs
cp probe.elf rootfs/probe.elf
python3 -c 'from qiling import Qiling; Qiling(["./rootfs/probe.elf"], "./rootfs").run()'

Qiling returns success for the SIZE_MAX request. Native Linux and QEMU RV64 return -1 with errno=ENOMEM; all tested runtimes return 0 for the one-page control.

Expected behavior

The overflowing range should fail with ENOMEM. The report covers the return value for a page-aligned mapped start and SIZE_MAX length; it does not claim the state of page permissions after the rejected request.

Additional context

Reproduced with Qiling v1.4.11 on RV64 Linux. Current dev commit 23ad4fd369a360ad7992d90cb7577f0241061c2b still calls ql.mem.protect(start, mlen, prot) and returns success if that call silently rejects the invalid range; see mman.py. The current dev source was checked statically, not dynamically run for this report.

Lenguaje dominante
Python
Estrellas
6.2k
Forks
806
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

  • Incluye un Dockerfile o un archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de qilingframework/qiling

Todos los issues de qilingframework/qiling

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.