Outgrown point-motion textures are kept until the context is destroyed
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 32/100
- Issue-Typ
- Bug
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- cpp
- Bereich
- computer-graphics, performance
Rechercherichtung
Start in clean/runtime/interop/executor_d3d12.cpp at point_texture (around line 404), where the point-motion texture is reallocated and the old one is pushed to retired_, and at the destructor (around line 61), the only place it is released. Check how mpoint_w_ and the render rectangle feed the growth path, and how the parked executor in clean/fsr/src/frontend.h keeps retired_ alive. Done means either a single maximum-size allocation from create, or retired textures released once external_done() reaches their recorded value, verified by a WARP test per #62. Read #62 and #64 first, since the ordering assumption depends on them.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
What happens
point_texture (clean/runtime/interop/executor_d3d12.cpp:404) reallocates the point-motion texture when a frame needs a larger one. The old texture is pushed to retired_ (:406), because a recorded list may still use it. The only release is in the destructor (:61).
Growth is monotonic (w = max(w, mpoint_w_), :407), so allocation stops once the largest render rectangle has been seen. The total is bounded by the sum over the first upward sweep.
When it can happen
Only with motion_outres=point, which is not the default (original is, clean/runtime/interop/backend.cpp:174, clean/FORMATS.md:692), and only when the game sets WG_CREATE_MOTION_OUTPUT_RES. The parked executor (clean/fsr/src/frontend.h:156) can keep retired_ alive across context re-creation with the same parameters.
A typical case is a few textures. The worst case is dynamic resolution that rises in many small steps, where the retired textures add up to a noticeable amount of VRAM on a smaller card.
Found by reading the code. It has not been reproduced.
To do
- Allocate
mpoint_once at the context's maximum render size taken from create. This removesretired_. The cost is one maximum-size texture, which the growth path reaches anyway. - Or record
external_recorded()when a texture is retired and release it inrecord()onceexternal_done()reaches that value. This relies on the ordering assumption in #64, which holds for a single context.
Test
WARP, using the executor seam described in #62. Feed frames with render widths 100, 101, 102, and so on, and assert that retired_ stays empty (maximum-size allocation) or drains after external_done() advances.
Related: #62, #64.
- Vorherrschende Sprache
- C++
- Sterne
- 12
- Forks
- 2
- Ø Merge
- 3 Std. 10 Min.
- Gemergte PRs (30 T.)
- 171
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus phantoslayer21/wronggpu
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 88/100
phantoslayer21/wronggpu#275 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
phantoslayer21/wronggpu#274 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 88/100
phantoslayer21/wronggpu#241 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug build
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 74/100
phantoslayer21/wronggpu#234 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug build
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 80/100
phantoslayer21/wronggpu#233 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in phantoslayer21/wronggpu
Ähnliche Issues
-
ai_p2
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 80/100
ClickHouse/ClickHouse#132519 ·
Maintainer antworten meist innerhalb von 1 Tag
-
[Bug]: VST3 getMidiControllerAssignment reads past midiControllerToParameter for program changeOffen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
juce-framework/JUCE#1810 ·
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 82/100
petercorke/robotics-toolbox-python#952 ·
Maintainer antworten meist innerhalb von 1 Tag
-
NatronRenderer: a Python error in the script (-t / project script) doesn't change the exit statusOffenfunc:engine type:bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
NatronGitHub/Natron#1276 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 1/5 1-3 Stunden Anfängerfreundlichkeit 77/100
Maintainer antworten meist innerhalb von 1 Tag