Outgrown point-motion textures are kept until the context is destroyed
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 32/100
- Tipo di issue
- Bug
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Stack tecnologico
- cpp
- Ambito
- computer-graphics, performance
Direzione di ricerca
Start in clean/runtime/interop/executor_d3d12.cpp at point_texture (around line 404), where the point-motion texture is reallocated and the old one is pushed to retired_, and at the destructor (around line 61), the only place it is released. Check how mpoint_w_ and the render rectangle feed the growth path, and how the parked executor in clean/fsr/src/frontend.h keeps retired_ alive. Done means either a single maximum-size allocation from create, or retired textures released once external_done() reaches their recorded value, verified by a WARP test per #62. Read #62 and #64 first, since the ordering assumption depends on them.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
What happens
point_texture (clean/runtime/interop/executor_d3d12.cpp:404) reallocates the point-motion texture when a frame needs a larger one. The old texture is pushed to retired_ (:406), because a recorded list may still use it. The only release is in the destructor (:61).
Growth is monotonic (w = max(w, mpoint_w_), :407), so allocation stops once the largest render rectangle has been seen. The total is bounded by the sum over the first upward sweep.
When it can happen
Only with motion_outres=point, which is not the default (original is, clean/runtime/interop/backend.cpp:174, clean/FORMATS.md:692), and only when the game sets WG_CREATE_MOTION_OUTPUT_RES. The parked executor (clean/fsr/src/frontend.h:156) can keep retired_ alive across context re-creation with the same parameters.
A typical case is a few textures. The worst case is dynamic resolution that rises in many small steps, where the retired textures add up to a noticeable amount of VRAM on a smaller card.
Found by reading the code. It has not been reproduced.
To do
- Allocate
mpoint_once at the context's maximum render size taken from create. This removesretired_. The cost is one maximum-size texture, which the growth path reaches anyway. - Or record
external_recorded()when a texture is retired and release it inrecord()onceexternal_done()reaches that value. This relies on the ordering assumption in #64, which holds for a single context.
Test
WARP, using the executor seam described in #62. Feed frames with render widths 100, 101, 102, and so on, and assert that retired_ stays empty (maximum-size allocation) or drains after external_done() advances.
Related: #62, #64.
- Lingua principale
- C++
- Stelle
- 12
- Fork
- 2
- Merge medio
- 3h 10m
- PR unite (30g)
- 171
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di phantoslayer21/wronggpu
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
phantoslayer21/wronggpu#275 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
phantoslayer21/wronggpu#274 ·
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
phantoslayer21/wronggpu#241 ·
I maintainer di solito rispondono entro 1 giorno
-
bug build
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
phantoslayer21/wronggpu#234 ·
I maintainer di solito rispondono entro 1 giorno
-
Launcher tests: "an older record: update available" fakes a version newer than the test buildApertabug build
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
phantoslayer21/wronggpu#233 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di phantoslayer21/wronggpu
Issue simili
-
ai_p2
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
ClickHouse/ClickHouse#132519 ·
I maintainer di solito rispondono entro 1 giorno
-
[Bug]: VST3 getMidiControllerAssignment reads past midiControllerToParameter for program changeAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
juce-framework/JUCE#1810 ·
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 82/100
petercorke/robotics-toolbox-python#952 ·
I maintainer di solito rispondono entro 1 giorno
-
NatronRenderer: a Python error in the script (-t / project script) doesn't change the exit statusApertafunc:engine type:bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
NatronGitHub/Natron#1276 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 1-3 ore Idoneità per principianti 77/100
I maintainer di solito rispondono entro 1 giorno