Titles: the later client's title system (name-line title, option toggles, title window)
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Anfängerfreundlichkeit
- 12/100
- Issue-Typ
- Feature
- Klarheit
- Muss geklärt werden
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- go, typescript
Rechercherichtung
Start from the disassembly notes in the issue, which point to a Binary Ninja database for build 1696 that a newcomer likely cannot access, and from overhead-layout.ts, the port's existing name-line layout. The unresolved parts are the title and achievement tables in Media.pk2 and the spawn and select packets that carry the title id, so the scope needs a maintainer decision first. Done means the title id rides spawn data, the name line prints through the title format, both option toggles work, and the title window posts the chat notice.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Split from #3256 (Title Manager and Achievements). The later native client, build 1696, has a full title system. That turns these two epic items from port-only into later-native features.
What the later client does (disassembly read, build 1696 database)
| Behaviour | Evidence | Checked by |
|---|---|---|
A character's title is printed inside the name line: the title's text is a format string that the name prints through, so with no title the format is "%s" |
CICharactor_BuildDisplayNameWithTitle 0x9689B0: title id at this+0x910 to GlobalDataManager_FindTitleById 0x877CA0, record +0x28 to the text manager, then WString_FormatBuffer(buf, 0x200, titleFormat, name) |
disassembly read |
| Two game options hide titles: your own (config +0x1F) and other players' (config +0x20) | same function; option labels UIIT_STT_CHAR_TITLE_SIGN / UIIT_STT_OTHER_TITLE_SIGN in CIFOptionGame_OnCreate 0xB16060 |
disassembly read |
Chat prints a titled sender as <Title>Name (UIIT_STT_TITLE_TITLE + "<%s>%s") with line colour 0xFFFFFF00 |
CIFChatViewer_FormatLinePrefix 0xBFE5B0 |
disassembly read |
Choosing a title posts <Title> to chat |
CIFTitle_PostCurrentTitleNotice 0xE31840 |
disassembly read |
A title window with categories 0-4, the title name, use time, feat and "untitled" (UIIT_STT_TITLE_CATEGORY_0..4, _NAME, _NAME2, _USE_TIME, _FEAT, _UNTITLE), plus achievement rewards that grant titles (UIIT_STT_ACHIEVE_UI_COMPLETE_REWARD) |
CIFTitle_BuildTitleTooltip 0xE2D180, CIFAchievement_BuildRewardText 0xE2A400 |
disassembly read |
The guild row is unchanged from v1.150: [Guild * Grant(Officer)], with the officer title only while the guild owns a fortress or fortress-war revival is active |
CICUser_RenderOverheadBoardPass 0x969A40 = v1.150 0x86B95B |
disassembly read; the port already matches (overhead-layout.ts) |
These functions are labelled in the build 1696 Binary Ninja database.
Still to read
- The title and achievement tables in that client's Media.pk2 (the title format strings and the categories): not extracted yet.
- The wire: how a spawn and the select packet carry
this+0x910, and the v1.188 server rule for granting titles.
Done when
The title id rides the spawn data. The name line prints through the title format, and both option toggles work. The title window lists owned titles, and choosing one posts the chat notice. The port's Contributor title (#3358, #3497) is drawn the same way, as a title on the name line.
- Vorherrschende Sprache
- Go
- Sterne
- 97
- Forks
- 61
- Ø Merge
- 4 Std. 14 Min.
- Gemergte PRs (30 T.)
- 913
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus opensro-dev/opensro
-
area: client enhancement priority: low
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
opensro-dev/opensro#3681 ·
Maintainer antworten meist innerhalb von 1 Tag
-
area: client bug priority: low
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
opensro-dev/opensro#3228 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
Format one minified client file with dprint (ongoing: one file per PR)Evtl. vergeben Ein verknüpfter Pull Request ist offen oder bereits gemergt. Offenarea: client enhancement good first issue priority: low
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
opensro-dev/opensro#1 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
area: server bug priority: medium
Schwierigkeit 3/5 Ein halber Tag Anfängerfreundlichkeit 55/100
opensro-dev/opensro#3687 ·
Maintainer antworten meist innerhalb von 1 Tag
-
area: ops bug priority: high
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 32/100
opensro-dev/opensro#3685 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in opensro-dev/opensro
Ähnliche Issues
-
area/networking kind/bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 69/100
siderolabs/talos#14972 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 72/100
Maintainer antworten meist innerhalb von 1 Tag
-
kubectl wait outputs cryptic "error: unrecognized condition: []" when --for is omittedEvtl. vergeben @muskan-creates352 hat das heute übernommen. Offenkind/bug needs-triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 84/100
kubernetes/kubectl#1910 · 1 Kommentar ·
-
needs-triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
stacklok/toolhive-catalog#1967 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
unbound-force/gaze#353 ·
Maintainer antworten meist innerhalb von 1 Tag