Titles: the later client's title system (name-line title, option toggles, title window)

Aberta
#3,502 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
5/5
Tempo estimado
Mais de uma semana
Facilidade para iniciantes
12/100
Tipo de issue
Funcionalidade
Clareza
Precisa de esclarecimento
Status de atividade
Ativa
Stack de tecnologia
go, typescript
Domínio
backend, game-dev

Direção de pesquisa

Start from the disassembly notes in the issue, which point to a Binary Ninja database for build 1696 that a newcomer likely cannot access, and from overhead-layout.ts, the port's existing name-line layout. The unresolved parts are the title and achievement tables in Media.pk2 and the spawn and select packets that carry the title id, so the scope needs a maintainer decision first. Done means the title id rides spawn data, the name line prints through the title format, both option toggles work, and the title window posts the chat notice.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

area: client area: server enhancement priority: high

Split from #3256 (Title Manager and Achievements). The later native client, build 1696, has a full title system. That turns these two epic items from port-only into later-native features.

What the later client does (disassembly read, build 1696 database)

Behaviour Evidence Checked by
A character's title is printed inside the name line: the title's text is a format string that the name prints through, so with no title the format is "%s" CICharactor_BuildDisplayNameWithTitle 0x9689B0: title id at this+0x910 to GlobalDataManager_FindTitleById 0x877CA0, record +0x28 to the text manager, then WString_FormatBuffer(buf, 0x200, titleFormat, name) disassembly read
Two game options hide titles: your own (config +0x1F) and other players' (config +0x20) same function; option labels UIIT_STT_CHAR_TITLE_SIGN / UIIT_STT_OTHER_TITLE_SIGN in CIFOptionGame_OnCreate 0xB16060 disassembly read
Chat prints a titled sender as <Title>Name (UIIT_STT_TITLE_TITLE + "<%s>%s") with line colour 0xFFFFFF00 CIFChatViewer_FormatLinePrefix 0xBFE5B0 disassembly read
Choosing a title posts <Title> to chat CIFTitle_PostCurrentTitleNotice 0xE31840 disassembly read
A title window with categories 0-4, the title name, use time, feat and "untitled" (UIIT_STT_TITLE_CATEGORY_0..4, _NAME, _NAME2, _USE_TIME, _FEAT, _UNTITLE), plus achievement rewards that grant titles (UIIT_STT_ACHIEVE_UI_COMPLETE_REWARD) CIFTitle_BuildTitleTooltip 0xE2D180, CIFAchievement_BuildRewardText 0xE2A400 disassembly read
The guild row is unchanged from v1.150: [Guild * Grant(Officer)], with the officer title only while the guild owns a fortress or fortress-war revival is active CICUser_RenderOverheadBoardPass 0x969A40 = v1.150 0x86B95B disassembly read; the port already matches (overhead-layout.ts)

These functions are labelled in the build 1696 Binary Ninja database.

Still to read

  • The title and achievement tables in that client's Media.pk2 (the title format strings and the categories): not extracted yet.
  • The wire: how a spawn and the select packet carry this+0x910, and the v1.188 server rule for granting titles.

Done when

The title id rides the spawn data. The name line prints through the title format, and both option toggles work. The title window lists owned titles, and choosing one posts the chat notice. The port's Contributor title (#3358, #3497) is drawn the same way, as a title on the name line.

Linguagem predominante
Go
Estrelas
97
Forks
61
Merge médio
4h 14min
PRs com merge (30d)
913

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de opensro-dev/opensro

Todas as issues de opensro-dev/opensro

Issues semelhantes

Mais issues de Go

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.