native: teleport arrivals are attackable at once; v1.188 spawn invincibility (status 0x0E, 10 s) is unported
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 20/100
Rechercherichtung
Start in returnscroll.go, portal.go, relocation.go, ground_scene.go and teleportprotection.go to see where noteTeleportArrival and startTeleportGrace are called, then read docs/agents/native-evidence.md. The main work is in the v1.188 binary: find every caller of SetSpawnInvincible at 0x004E0C60 with a non-zero argument, and record what status 0x0E does to targeting and damage. Done when the native-claims table has those addresses and the port either adds the 10 s state or closes the issue with the evidence.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Owner report: after a reverse return scroll (or any return / gate teleport), monsters and players can attack the arriving character at once. On the original the owner remembers a few seconds (about 5 s) in which nobody could attack them.
What the port does today
completeReturnScroll(returnscroll.go),commitGateTravel(portal.go) andrelocateCharacter(relocation.go) callnoteTeleportArrival.ReconcileScene(ground_scene.go) then callsstartTeleportGraceat game-ready (teleportprotection.go).- That grace is port-only, behind
SRO_TELEPORT_GRACE, default off (#1518, owner decision 2026-10-25). With it off, which is what ships (the shard settings table and the Nomad job both default it off), an arrival is touchable from game-ready. - With it on, the arrival gets body mode 2 (the revival's untouchable state) for 6 s, or 11 s in a siege world. Monsters skip the player, and the player cannot attack.
Why #1518 called it not native
The #1518 review read the reference server at assembly level for a body mode 2 grant. It found one only on the revival arm of the town-teleport routine. The teleport-use handler (scrolls and gates), GM moves and world entry pass the no-grant arm. The two reviews disagreed on whether return scrolls fall in the town-return class.
New lead the #1518 review did not cover
The v1.188 reconstruction (skillman1337 vsro-server-decomp, SR_GameServer/GObjPC.cpp) has a separate spawn-protection state that is not body mode 2:
CGObjPC::SetSpawnInvincibleat native0x004E0C60(237 bytes), on bytetagCharData +0x13. Its comment describes the assembly: a non-zero value adds status0x0Ewith duration 10.0 to the status map at+0x1D8. Zero removes it and broadcasts0x3042(object id, remaining level).CGObjChar::OnMsg_SkillAction(0x004B21B0) callsSetSpawnInvincible(0): the player's own skill or attack action ends it early.- The reconstruction leaves the setter a stub, and its callers with a non-zero argument are not identified. "Spawn" suggests world entry, and every teleport in SRO re-enters the world. That is an inference, not checked.
This is decompiler output plus a reconstruction comment, a hypothesis until the disassembly confirms it (docs/agents/native-evidence.md). If it holds, the native behaviour the owner remembers is this state, not the revival's body mode 2, and it ships on by default as native.
To settle in the v1.188 binary
- Every caller of
0x004E0C60with a non-zero argument: world entry, the teleport-use handler, scroll and gate completions, login, revival. - What status
0x0Edoes to targeting: whether monster target selection and player-versus-player checks skip it, and whether it refuses damage. - Everything that clears it besides
OnMsg_SkillAction, such as movement or item use. - The
0x3042wire in the v1.150 client: whether the client handles it, and what it shows.
Done when
- The native callers and effect are recorded with addresses (native-claims table).
- If native: teleport arrivals get the state for 10 s (from game-ready, as #1518 reasoned), the player's first action ends it, monsters do not pick the player meanwhile, and it ships on by default. Tests cover each travel owner, the expiry and the early end.
SRO_TELEPORT_GRACEis retired or kept as the separate, non-native revival-length variant. - If not native: the issue closes with the evidence, and the owner decides whether to turn
SRO_TELEPORT_GRACEon for the shard.
- Vorherrschende Sprache
- Go
- Sterne
- 97
- Forks
- 61
- Ø Merge
- 4 Std. 14 Min.
- Gemergte PRs (30 T.)
- 913
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus opensro-dev/opensro
-
area: client enhancement priority: low
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
opensro-dev/opensro#3681 ·
Maintainer antworten meist innerhalb von 1 Tag
-
area: client bug priority: low
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
opensro-dev/opensro#3228 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
Format one minified client file with dprint (ongoing: one file per PR)Evtl. vergeben Ein verknüpfter Pull Request ist offen oder bereits gemergt. Offenarea: client enhancement good first issue priority: low
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
opensro-dev/opensro#1 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
area: server bug priority: medium
Schwierigkeit 3/5 Ein halber Tag Anfängerfreundlichkeit 55/100
opensro-dev/opensro#3687 ·
Maintainer antworten meist innerhalb von 1 Tag
-
area: ops bug priority: high
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 32/100
opensro-dev/opensro#3685 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in opensro-dev/opensro
Ähnliche Issues
-
area/networking kind/bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 69/100
siderolabs/talos#14972 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 72/100
Maintainer antworten meist innerhalb von 1 Tag
-
kubectl wait outputs cryptic "error: unrecognized condition: []" when --for is omittedEvtl. vergeben @muskan-creates352 hat das heute übernommen. Offenkind/bug needs-triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 84/100
kubernetes/kubectl#1910 · 1 Kommentar ·
-
needs-triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
stacklok/toolhive-catalog#1967 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
unbound-force/gaze#353 ·
Maintainer antworten meist innerhalb von 1 Tag