native: teleport arrivals are attackable at once; v1.188 spawn invincibility (status 0x0E, 10 s) is unported

Đang mở
#3,284 3 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức phù hợp với người mới
20/100
Loại issue
Lỗi
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
go, reverse-engineering
Lĩnh vực
backend, game-dev

Hướng nghiên cứu

Start in returnscroll.go, portal.go, relocation.go, ground_scene.go and teleportprotection.go to see where noteTeleportArrival and startTeleportGrace are called, then read docs/agents/native-evidence.md. The main work is in the v1.188 binary: find every caller of SetSpawnInvincible at 0x004E0C60 with a non-zero argument, and record what status 0x0E does to targeting and damage. Done when the native-claims table has those addresses and the port either adds the 10 s state or closes the issue with the evidence.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

area: server bug priority: high

Owner report: after a reverse return scroll (or any return / gate teleport), monsters and players can attack the arriving character at once. On the original the owner remembers a few seconds (about 5 s) in which nobody could attack them.

What the port does today

  • completeReturnScroll (returnscroll.go), commitGateTravel (portal.go) and relocateCharacter (relocation.go) call noteTeleportArrival. ReconcileScene (ground_scene.go) then calls startTeleportGrace at game-ready (teleportprotection.go).
  • That grace is port-only, behind SRO_TELEPORT_GRACE, default off (#1518, owner decision 2026-10-25). With it off, which is what ships (the shard settings table and the Nomad job both default it off), an arrival is touchable from game-ready.
  • With it on, the arrival gets body mode 2 (the revival's untouchable state) for 6 s, or 11 s in a siege world. Monsters skip the player, and the player cannot attack.

Why #1518 called it not native

The #1518 review read the reference server at assembly level for a body mode 2 grant. It found one only on the revival arm of the town-teleport routine. The teleport-use handler (scrolls and gates), GM moves and world entry pass the no-grant arm. The two reviews disagreed on whether return scrolls fall in the town-return class.

New lead the #1518 review did not cover

The v1.188 reconstruction (skillman1337 vsro-server-decomp, SR_GameServer/GObjPC.cpp) has a separate spawn-protection state that is not body mode 2:

  • CGObjPC::SetSpawnInvincible at native 0x004E0C60 (237 bytes), on byte tagCharData +0x13. Its comment describes the assembly: a non-zero value adds status 0x0E with duration 10.0 to the status map at +0x1D8. Zero removes it and broadcasts 0x3042 (object id, remaining level).
  • CGObjChar::OnMsg_SkillAction (0x004B21B0) calls SetSpawnInvincible(0): the player's own skill or attack action ends it early.
  • The reconstruction leaves the setter a stub, and its callers with a non-zero argument are not identified. "Spawn" suggests world entry, and every teleport in SRO re-enters the world. That is an inference, not checked.

This is decompiler output plus a reconstruction comment, a hypothesis until the disassembly confirms it (docs/agents/native-evidence.md). If it holds, the native behaviour the owner remembers is this state, not the revival's body mode 2, and it ships on by default as native.

To settle in the v1.188 binary

  1. Every caller of 0x004E0C60 with a non-zero argument: world entry, the teleport-use handler, scroll and gate completions, login, revival.
  2. What status 0x0E does to targeting: whether monster target selection and player-versus-player checks skip it, and whether it refuses damage.
  3. Everything that clears it besides OnMsg_SkillAction, such as movement or item use.
  4. The 0x3042 wire in the v1.150 client: whether the client handles it, and what it shows.

Done when

  • The native callers and effect are recorded with addresses (native-claims table).
  • If native: teleport arrivals get the state for 10 s (from game-ready, as #1518 reasoned), the player's first action ends it, monsters do not pick the player meanwhile, and it ships on by default. Tests cover each travel owner, the expiry and the early end. SRO_TELEPORT_GRACE is retired or kept as the separate, non-native revival-length variant.
  • If not native: the issue closes with the evidence, and the owner decides whether to turn SRO_TELEPORT_GRACE on for the shard.
Ngôn ngữ chính
Go
Star
97
Fork
61
Merge trung bình
4 giờ 14 phút
Pull request đã merge (30 ngày)
913

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của opensro-dev/opensro

Tất cả issue của opensro-dev/opensro

Issue tương tự

Thêm issue về Go

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.