memory: clean up active lock files on exit and termination signals

Offen
  • Stimmt etwas nicht?
#5,485 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@Faris-as arbeitet bereits daran.

Seit 06.11.2026.

  • #1 von @Faris-as — offen

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
25/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
docker, node.js, typescript
Bereich
backend, devops

Rechercherichtung

Read src/memory/index.ts, the lock handling in file-lock.test.ts, and src/memory/Dockerfile; compare signal handling with src/everything/transports/stdio.ts and src/everything/Dockerfile. Check the linked prototype branch for existing work. Done means active locks owned by this process are cleaned up on shutdown, locks owned by others are preserved, the Docker stop signal is configured, and the memory tests pass.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Which server?

memory (@modelcontextprotocol/server-memory)

Server version

2.1.0

How did you run the server?

From a clone of this repository

Transport

stdio

Protocol era

Modern (2026-07-28)

MCP client and version

Claude Desktop / Autonomous Agent Orchestrator

Operating system and runtime

Linux / Node.js v24+

Server configuration
{
  "mcpServers": {
    "memory": {
      "command": "npx",
      "args": ["-y", "@modelcontextprotocol/server-memory"]
    }
  }
}
Steps to reproduce
  1. Run @modelcontextprotocol/server-memory.
  2. Dispatch a mutation tool call (e.g. create_entities or add_observations) that acquires the lock via withFileLock.
  3. Terminate or stop the server process via SIGINT, SIGTERM, client disconnect, or container stop during the operation.
  4. Inspect the directory holding memory.jsonl.
  5. Attempt a subsequent write from another agent or container sharing the same graph file.
Expected behavior

The server should register signal handlers (SIGINT, SIGTERM) and exit cleanup hooks to remove any active lock file it currently holds, preventing orphaned lock files on abrupt shutdown.

Actual behavior

In Node.js, asynchronous finally blocks in withFileLock do not run when terminated by signals. Because src/memory registers no signal handlers (unlike src/everything/transports/stdio.ts), memory.jsonl.lock remains stranded on disk.
In multi-container or Docker environments where hostname !== os.hostname(), isLockOwnerDead returns false, forcing other agents to stall for up to 30–60 seconds before breaking the stale lock.
Additionally, in src/memory/Dockerfile, Node runs as PID 1 without STOPSIGNAL SIGINT, causing PID 1 to ignore SIGINT by default.

Already prototyped a fix?

Prompt for maintainer workflow:

"In src/memory/index.ts, track active lock files held by this process in an activeLocks map. On process exit and on SIGINT/SIGTERM, synchronously check if the lock file still contains our token, and if so, unlink it to avoid leaving stranded locks on abrupt shutdown. Add STOPSIGNAL SIGINT to src/memory/Dockerfile matching src/everything/Dockerfile. Add unit tests in file-lock.test.ts verifying active lock tracking and that cleanup leaves locks owned by another process intact."

Verification:

Before you submit
  • I searched existing issues and this is not a duplicate.
  • This is not a security vulnerability report.
Vorherrschende Sprache
TypeScript
Sterne
91.7k
Forks
11.9k
Ø Merge
3 Std. 30 Min.
Gemergte PRs (30 T.)
199

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus modelcontextprotocol/servers

Alle Issues in modelcontextprotocol/servers

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.