Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

Stop the JSONRPC server cleanly on stdin EOF instead of busy-looping

Offen
#529 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
50/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
rust
Bereich
api, backend, testing-qa

Rechercherichtung

Start at crates/pet-jsonrpc/src/server.rs, especially start_server, and trace the transport read loop and shutdown path. Reproduce the stdin-EOF behavior with the bounded subprocess harness described in the issue, then add injectable-reader tests for clean and truncated EOF cases plus read errors. Done means deterministic cleanup and successful exit within one second across platforms without disrupting valid streaming.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

bug

Tracking plan: #528
Priority: P1. Evidence: reproduced on Windows at 4e523ba.

Problem

The server treats stdin EOF as an empty header and immediately repeats the read/error loop instead of exiting. In a bounded reproduction, closing stdin after a successful info exchange left PET alive after 251 ms, consuming 234 ms of CPU and writing at least 991,232 bytes to stderr.

Source: start_server.

Reproduction

Start pet server with piped stdin/stdout/stderr. Send a correctly framed info request and wait for its response. Close the parent's stdin pipe while continuing to drain stderr. Observe that PET does not exit and repeatedly logs a missing Content-Length error. Use a bounded harness that terminates only its own child after observing the behavior.

Scope

  • Treat EOF at the next-frame boundary as normal termination; distinguish truncated headers/payloads from clean EOF.
  • Return from the transport loop rather than using an unconditional diverging loop, and define server shutdown/worker cleanup behavior.
  • Keep broken-pipe/read/write failures explicit without retrying indefinitely or polluting protocol stdout.
  • Make the transport reader injectable so EOF and partial-read tests do not require a permanently running server.

Acceptance criteria

  • Closing stdin after a normal exchange exits the subprocess successfully within 1 second on Windows, Linux, and macOS, without a busy loop or error flood.
  • Clean EOF, EOF during a header, EOF during a payload, and actual read errors have deterministic tests and documented outcomes.
  • Shutdown during an active request does not leave orphaned work or wait forever; cleanup semantics are tested.
  • Existing valid request/notification streaming continues to work.
  • Test clients can request normal shutdown/close input and use forced termination only as a bounded failure fallback.

Dependencies

No prerequisite. Land early: correct shutdown enables trustworthy coverage collection from server subprocesses. Keep framing/ID expansion in its separate issue under #528.

Vorherrschende Sprache
Rust
Sterne
207
Forks
45
Ø Merge
3 T. 6 Std.
Gemergte PRs (30 T.)
12

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus microsoft/python-environment-tools

Alle Issues in microsoft/python-environment-tools

Ähnliche Issues

Weitere Issues zu Rust

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.