Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Stop the JSONRPC server cleanly on stdin EOF instead of busy-looping

Aberta
#529 1 comentário 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
50/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
rust
Domínio
api, backend, testing-qa

Direção de pesquisa

Start at crates/pet-jsonrpc/src/server.rs, especially start_server, and trace the transport read loop and shutdown path. Reproduce the stdin-EOF behavior with the bounded subprocess harness described in the issue, then add injectable-reader tests for clean and truncated EOF cases plus read errors. Done means deterministic cleanup and successful exit within one second across platforms without disrupting valid streaming.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

bug

Tracking plan: #528
Priority: P1. Evidence: reproduced on Windows at 4e523ba.

Problem

The server treats stdin EOF as an empty header and immediately repeats the read/error loop instead of exiting. In a bounded reproduction, closing stdin after a successful info exchange left PET alive after 251 ms, consuming 234 ms of CPU and writing at least 991,232 bytes to stderr.

Source: start_server.

Reproduction

Start pet server with piped stdin/stdout/stderr. Send a correctly framed info request and wait for its response. Close the parent's stdin pipe while continuing to drain stderr. Observe that PET does not exit and repeatedly logs a missing Content-Length error. Use a bounded harness that terminates only its own child after observing the behavior.

Scope

  • Treat EOF at the next-frame boundary as normal termination; distinguish truncated headers/payloads from clean EOF.
  • Return from the transport loop rather than using an unconditional diverging loop, and define server shutdown/worker cleanup behavior.
  • Keep broken-pipe/read/write failures explicit without retrying indefinitely or polluting protocol stdout.
  • Make the transport reader injectable so EOF and partial-read tests do not require a permanently running server.

Acceptance criteria

  • Closing stdin after a normal exchange exits the subprocess successfully within 1 second on Windows, Linux, and macOS, without a busy loop or error flood.
  • Clean EOF, EOF during a header, EOF during a payload, and actual read errors have deterministic tests and documented outcomes.
  • Shutdown during an active request does not leave orphaned work or wait forever; cleanup semantics are tested.
  • Existing valid request/notification streaming continues to work.
  • Test clients can request normal shutdown/close input and use forced termination only as a bounded failure fallback.

Dependencies

No prerequisite. Land early: correct shutdown enables trustworthy coverage collection from server subprocesses. Keep framing/ID expansion in its separate issue under #528.

Linguagem predominante
Rust
Estrelas
207
Forks
45
Merge médio
3d 6h
PRs com merge (30d)
12

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de microsoft/python-environment-tools

Todas as issues de microsoft/python-environment-tools

Issues semelhantes

Mais issues de Rust

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.