Apply consistent access checks across Studio endpoints

Offen
#6,398 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
49/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
python

Rechercherichtung

Start in the hotfixes viewsets and plain views, then inspect neighbouring endpoints for their permission-scoped query patterns. Check serializers for requester fields and review tests around the Stripe webhook, logout, and public channel token endpoints. Add regression coverage for each access denial or refused request; done means every scoped gap follows the stated pattern and its regression test passes.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

DEV: backend

Overview

Several Studio endpoints don't apply the access checks the rest of the API follows. Some viewset actions query models directly instead of through the permission-scoped queryset. Some writable fields should come from the logged-in user. Some views accept requests they should refuse. Each sub-issue closes one gap so it matches the access pattern of its neighbouring endpoints.

Scope
  • Included: viewset actions and plain views on hotfixes whose access check is missing or weaker than their neighbours'.
  • Included: request hardening next to those checks: the Stripe webhook secret, logout over GET, and rate limits on the public channel token endpoints.
  • Excluded: the /api/internal/* endpoints, which are to be deprecated.
  • Excluded: organization role management, which #6312–#6315 track.
Guidance
  • Target hotfixes.
  • Each access-check fix needs a regression test showing that a user without access gets the same response as for a nonexistent object. Each hardening fix needs a regression test for the request it now refuses.
Strategy
  • Viewset actions load objects through get_object() / get_edit_object(), or the model's filter_view_queryset / filter_edit_queryset, never Model.objects directly.
  • A field that identifies the requester is read-only in the serializer and set from request.user.

AI usage

I chose which audit findings belong here and set the access pattern. Claude Code found and reproduced each gap and drafted this issue.

Vorherrschende Sprache
Python
Sterne
212
Forks
321
Ø Merge
1 T. 7 Std.
Gemergte PRs (30 T.)
14

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus learningequality/studio

Alle Issues in learningequality/studio

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.