Apply consistent access checks across Studio endpoints

Aperta
#6,398 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
49/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
python

Direzione di ricerca

Start in the hotfixes viewsets and plain views, then inspect neighbouring endpoints for their permission-scoped query patterns. Check serializers for requester fields and review tests around the Stripe webhook, logout, and public channel token endpoints. Add regression coverage for each access denial or refused request; done means every scoped gap follows the stated pattern and its regression test passes.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

DEV: backend

Overview

Several Studio endpoints don't apply the access checks the rest of the API follows. Some viewset actions query models directly instead of through the permission-scoped queryset. Some writable fields should come from the logged-in user. Some views accept requests they should refuse. Each sub-issue closes one gap so it matches the access pattern of its neighbouring endpoints.

Scope
  • Included: viewset actions and plain views on hotfixes whose access check is missing or weaker than their neighbours'.
  • Included: request hardening next to those checks: the Stripe webhook secret, logout over GET, and rate limits on the public channel token endpoints.
  • Excluded: the /api/internal/* endpoints, which are to be deprecated.
  • Excluded: organization role management, which #6312–#6315 track.
Guidance
  • Target hotfixes.
  • Each access-check fix needs a regression test showing that a user without access gets the same response as for a nonexistent object. Each hardening fix needs a regression test for the request it now refuses.
Strategy
  • Viewset actions load objects through get_object() / get_edit_object(), or the model's filter_view_queryset / filter_edit_queryset, never Model.objects directly.
  • A field that identifies the requester is read-only in the serializer and set from request.user.

AI usage

I chose which audit findings belong here and set the access pattern. Claude Code found and reproduced each gap and drafted this issue.

Lingua principale
Python
Stelle
212
Fork
321
Merge medio
1g 7h
PR unite (30g)
14

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di learningequality/studio

Tutte le issue di learningequality/studio

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.