teeny-request: the timeout option is ignored since 10.0.0 (node-fetch 3 has no timeout option)

Offen
#9,514 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
63/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
javascript, node.js
Bereich
networking

Rechercherichtung

Start at requestToFetchOptions, where reqOpts.timeout is copied into node-fetch 3 options that no longer honor it; the reproduction script in the issue is the test to run, and done means the callback fires after ~1000 ms with a timeout error instead of hanging. Run it against the installed teeny-request build before changing anything to confirm the regression. Heed the issue's caveat that a blanket AbortSignal.timeout would truncate streaming downloads, so inspect the streaming path and decide between a signal and an agent socket idle timeout.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Library name

teeny-request

Versions

teeny-request 11.0.1 (also 10.x), node-fetch 3.3.2, Node.js 22.22.1

Description

requestToFetchOptions copies reqOpts.timeout into the node-fetch options. node-fetch 3 removed the timeout option, so the value is silently ignored, and a request to a server that never responds waits forever.

This is a regression from teeny-request 10.0.0, which moved from node-fetch 2 to node-fetch 3. With teeny-request 9.0.0 (node-fetch 2.7.0), the same request fails after the timeout.

It affects every library that passes timeout to teeny-request. For example, @google-cloud/storage sets timeout: 60000 as a default for all requests (nodejs-common/util.js). Since storage 8.0.1, which depends on teeny-request ^11, that timeout has no effect.

Reproduction
const http = require('node:http')
const { teenyRequest } = require('teeny-request')

// The server accepts the request and never sends response headers.
const server = http.createServer(() => {})
server.listen(0, () => {
  const url = `http://127.0.0.1:${server.address().port}/`
  const startedAt = Date.now()
  teenyRequest({ uri: url, timeout: 1000 }, (err) => {
    console.log(`callback after ${Date.now() - startedAt} ms:`, err?.message)
    process.exit(0)
  })
  setTimeout(() => {
    console.log(`no callback after ${Date.now() - startedAt} ms`)
    process.exit(1)
  }, 5000)
})

Output with teeny-request 11.0.1 (node-fetch 3.3.2):

no callback after 5010 ms

Output with teeny-request 9.0.0 (node-fetch 2.7.0):

callback after 1003 ms: network timeout at: http://127.0.0.1:50922/
Expected behavior

The request fails after about 1000 ms, as it does with teeny-request 9.x.

One possible fix is to pass signal: AbortSignal.timeout(reqOpts.timeout) to fetch. That limits the total request time, which would cut off long streaming downloads, so streaming requests may need a socket idle timeout on the agent instead. In node-fetch 2, the timeout stopped at the response headers for a streamed body.

Related: #9515 (a stalled @google-cloud/storage download never errors).

Vorherrschende Sprache
TypeScript
Sterne
3.2k
Forks
732
Ø Merge
2 T. 11 Std.
Gemergte PRs (30 T.)
99

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus googleapis/google-cloud-node

Alle Issues in googleapis/google-cloud-node

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.