teeny-request: the timeout option is ignored since 10.0.0 (node-fetch 3 has no timeout option)

Ouverte
#9,514 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
63/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
javascript, node.js
Domaine
networking

Piste de recherche

Start at requestToFetchOptions, where reqOpts.timeout is copied into node-fetch 3 options that no longer honor it; the reproduction script in the issue is the test to run, and done means the callback fires after ~1000 ms with a timeout error instead of hanging. Run it against the installed teeny-request build before changing anything to confirm the regression. Heed the issue's caveat that a blanket AbortSignal.timeout would truncate streaming downloads, so inspect the streaming path and decide between a signal and an agent socket idle timeout.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Library name

teeny-request

Versions

teeny-request 11.0.1 (also 10.x), node-fetch 3.3.2, Node.js 22.22.1

Description

requestToFetchOptions copies reqOpts.timeout into the node-fetch options. node-fetch 3 removed the timeout option, so the value is silently ignored, and a request to a server that never responds waits forever.

This is a regression from teeny-request 10.0.0, which moved from node-fetch 2 to node-fetch 3. With teeny-request 9.0.0 (node-fetch 2.7.0), the same request fails after the timeout.

It affects every library that passes timeout to teeny-request. For example, @google-cloud/storage sets timeout: 60000 as a default for all requests (nodejs-common/util.js). Since storage 8.0.1, which depends on teeny-request ^11, that timeout has no effect.

Reproduction
const http = require('node:http')
const { teenyRequest } = require('teeny-request')

// The server accepts the request and never sends response headers.
const server = http.createServer(() => {})
server.listen(0, () => {
  const url = `http://127.0.0.1:${server.address().port}/`
  const startedAt = Date.now()
  teenyRequest({ uri: url, timeout: 1000 }, (err) => {
    console.log(`callback after ${Date.now() - startedAt} ms:`, err?.message)
    process.exit(0)
  })
  setTimeout(() => {
    console.log(`no callback after ${Date.now() - startedAt} ms`)
    process.exit(1)
  }, 5000)
})

Output with teeny-request 11.0.1 (node-fetch 3.3.2):

no callback after 5010 ms

Output with teeny-request 9.0.0 (node-fetch 2.7.0):

callback after 1003 ms: network timeout at: http://127.0.0.1:50922/
Expected behavior

The request fails after about 1000 ms, as it does with teeny-request 9.x.

One possible fix is to pass signal: AbortSignal.timeout(reqOpts.timeout) to fetch. That limits the total request time, which would cut off long streaming downloads, so streaming requests may need a socket idle timeout on the agent instead. In node-fetch 2, the timeout stopped at the response headers for a streamed body.

Related: #9515 (a stalled @google-cloud/storage download never errors).

Langage dominant
TypeScript
Étoiles
3.2k
Forks
732
Merge moyen
2 j 11 h
PR mergées (30 j)
99

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de googleapis/google-cloud-node

Toutes les issues de googleapis/google-cloud-node

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.