Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

AsyncioIntegration hides an eager task factory from anyio, which breaks anyio task groups

Offen
#7,709 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
68/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
python

Rechercherichtung

Start in sentry_sdk/integrations/asyncio.py at AsyncioIntegration and _sentry_task_factory, then reproduce the failure with Python 3.12+, anyio 4.8+, and the example in the issue. Check the eager-task-factory handling against asyncio.create_eager_task_factory(). Done means anyio recognizes the installed factory, task groups exit normally, and existing span behavior remains intact.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Bug Waiting for: Product Owner
How do you use Sentry?

Sentry Saas (sentry.io)

Version

2.70.0

Steps to Reproduce

Python 3.12 or later, anyio 4.8 or later.

import asyncio

import anyio
import sentry_sdk
from sentry_sdk.integrations.asyncio import AsyncioIntegration


async def child(event):
    await event.wait()


async def main():
    asyncio.get_running_loop().set_task_factory(asyncio.eager_task_factory)
    sentry_sdk.init(integrations=[AsyncioIntegration()])

    async with anyio.create_task_group() as tg:
        tg.start_soon(child, anyio.Event())
        await anyio.sleep(0.01)
        tg.cancel_scope.cancel()


asyncio.run(main())
Expected Result

The task group exits normally, as it does without AsyncioIntegration.

Actual Result
ExceptionGroup: unhandled errors in a TaskGroup (1 sub-exception)
  RuntimeError: Attempted to exit a cancel scope that isn't the current tasks's current cancel scope
Cause

anyio starts the children of a task group non-eagerly, whatever the loop's task factory.
To do that it has to recognise an eager task factory, and asyncio offers no public way to ask.
anyio compares factory.__code__ with asyncio.eager_task_factory.__code__, which every factory returned by asyncio.create_eager_task_factory() shares, and then calls the task constructor from the factory's closure.

AsyncioIntegration replaces the loop's task factory with _sentry_task_factory, a plain function that calls the original.
Its code object is its own, so anyio takes it for an ordinary factory, the child starts eagerly inside create_task(), and anyio's bookkeeping for the task is written after the task has already run.

Proposed fix

When the original factory is an eager one, install a factory built with asyncio.create_eager_task_factory() and wrap the coroutine in its task constructor.
Tasks stay eager, spans are created as before, and anyio recognises the factory.
I have a patch with tests and can open a PR if this approach is acceptable.

Vorherrschende Sprache
Python
Sterne
2.2k
Forks
672
Ø Merge
22 Std. 8 Min.
Gemergte PRs (30 T.)
228

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus getsentry/sentry-python

Alle Issues in getsentry/sentry-python

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.