AsyncioIntegration hides an eager task factory from anyio, which breaks anyio task groups
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 68/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- python
研究方向
Start in sentry_sdk/integrations/asyncio.py at AsyncioIntegration and _sentry_task_factory, then reproduce the failure with Python 3.12+, anyio 4.8+, and the example in the issue. Check the eager-task-factory handling against asyncio.create_eager_task_factory(). Done means anyio recognizes the installed factory, task groups exit normally, and existing span behavior remains intact.
由索引模型根據 Issue 內容生成。
描述
How do you use Sentry?
Sentry Saas (sentry.io)
Version
2.70.0
Steps to Reproduce
Python 3.12 or later, anyio 4.8 or later.
import asyncio
import anyio
import sentry_sdk
from sentry_sdk.integrations.asyncio import AsyncioIntegration
async def child(event):
await event.wait()
async def main():
asyncio.get_running_loop().set_task_factory(asyncio.eager_task_factory)
sentry_sdk.init(integrations=[AsyncioIntegration()])
async with anyio.create_task_group() as tg:
tg.start_soon(child, anyio.Event())
await anyio.sleep(0.01)
tg.cancel_scope.cancel()
asyncio.run(main())
Expected Result
The task group exits normally, as it does without AsyncioIntegration.
Actual Result
ExceptionGroup: unhandled errors in a TaskGroup (1 sub-exception)
RuntimeError: Attempted to exit a cancel scope that isn't the current tasks's current cancel scope
Cause
anyio starts the children of a task group non-eagerly, whatever the loop's task factory.
To do that it has to recognise an eager task factory, and asyncio offers no public way to ask.
anyio compares factory.__code__ with asyncio.eager_task_factory.__code__, which every factory returned by asyncio.create_eager_task_factory() shares, and then calls the task constructor from the factory's closure.
AsyncioIntegration replaces the loop's task factory with _sentry_task_factory, a plain function that calls the original.
Its code object is its own, so anyio takes it for an ordinary factory, the child starts eagerly inside create_task(), and anyio's bookkeeping for the task is written after the task has already run.
Proposed fix
When the original factory is an eager one, install a factory built with asyncio.create_eager_task_factory() and wrap the coroutine in its task constructor.
Tasks stay eager, spans are created as before, and anyio recognises the factory.
I have a patch with tests and can open a PR if this approach is acceptable.
- 主要語言
- Python
- 星號
- 2.2k
- 分支
- 672
- 平均合併
- 19 小時 30 分鐘
- 30 天內合併 PR
- 215
環境準備
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
getsentry/sentry-python 的其他 Issue
-
Python Task
難度 2/5 1-3 小時 新手友好度 65/100
getsentry/sentry-python#7668 · 1 則留言 ·
維護者通常 1 天內回覆
-
Python Task
難度 2/5 1-3 小時 新手友好度 65/100
getsentry/sentry-python#7663 · 1 則留言 ·
維護者通常 1 天內回覆
-
Python Task
難度 2/5 1-3 小時 新手友好度 65/100
getsentry/sentry-python#7652 · 1 則留言 ·
維護者通常 1 天內回覆
-
Remove send_default_pii from httpx可能已有人在做 @sentrivana 於 4 天前認領。 未關閉Python
難度 2/5 1-3 小時 新手友好度 65/100
getsentry/sentry-python#7653 · 1 則留言 · 已指派 1 人 ·
維護者通常 1 天內回覆
-
Remove send_default_pii from httpx2可能已有人在做 @sentrivana 於 4 天前認領。 未關閉Python
難度 2/5 1-3 小時 新手友好度 65/100
getsentry/sentry-python#7654 · 1 則留言 · 已指派 1 人 ·
維護者通常 1 天內回覆
查看 getsentry/sentry-python 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 86/100
維護者通常 1 天內回覆
-
難度 2/5 1-2 天 新手友好度 70/100
-
難度 2/5 1-3 小時 新手友好度 88/100
維護者通常 7 天內回覆
-
難度 2/5 1-3 小時 新手友好度 70/100
lmstudio-ai/mlx-engine#376 ·
-
難度 2/5 1-3 小時 新手友好度 72/100
pyiron/bagofholding#166 ·