A release would push the admin halves without the packages they depend on

Offen
#3,453 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
68/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
csharp, github-actions
Bereich
ci-cd, release

Rechercherichtung

Start with .github/workflows/publish.yml around lines 205–208, then inspect the two cited project files to confirm package dependencies and template defaults. Run or add a publish dry run that lists packages and their FluentCMS dependencies; done means no listed package has an unlisted FluentCMS dependency, and release notes explain using --admin false until A-47.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area:admin area:build type:bug

Problem

The Publish workflow keeps the admin out of a release by removing FluentCMS.Admin*.nupkg and .snupkg after the pack (.github/workflows/publish.yml, lines 205 to 208). The pattern does not match FluentCMS.Plugins.Media.Admin, which is packable (admin/src/plugins/FluentCMS.Plugins.Media.Admin/FluentCMS.Plugins.Media.Admin.csproj) and depends on FluentCMS.Admin.Abstractions and FluentCMS.Admin.Components, both removed. A6 adds five more halves of the same name shape. FluentCMS.Templates is pushed too, and dotnet new fluentcms-plugin writes an admin half by default that references the same two packages (templates/fluentcms-plugin/src/FluentCms-Plugin1.Admin/FluentCms-Plugin1.Admin.csproj). 1.0.0-preview.1 was tagged on 16 Nov 2026, before the media half and the template's half existed, so no release has met this. A release cut from main today would push a package that cannot be restored and a template whose default output does not restore from nuget.org. Read from the workflow file; no dry run was made to see the list.

Proposal

Until A-47: remove FluentCMS.Plugins.*.Admin as well, and say in the notes of a release that dotnet new fluentcms-plugin takes --admin false until the admin is released; or have the dry run fail when a package to push depends on a FluentCMS package that is not among them.

Acceptance

  • A dry run lists no package that depends on a FluentCMS package it does not list
  • The notes of a release before A-47 say how to use the plugin template

Found while A7 was planned (20 Nov 2026). Matters only if a release is tagged before A-47. Size: S.

Vorherrschende Sprache
C#
Sterne
567
Forks
107
Ø Merge
1 Std. 19 Min.
Gemergte PRs (30 T.)
353

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus fluentcms/FluentCMS

Alle Issues in fluentcms/FluentCMS

Ähnliche Issues

Weitere Issues zu C#

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.