A release would push the admin halves without the packages they depend on

Aperta
#3,453 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
68/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
csharp, github-actions
Ambito
ci-cd, release

Direzione di ricerca

Start with .github/workflows/publish.yml around lines 205–208, then inspect the two cited project files to confirm package dependencies and template defaults. Run or add a publish dry run that lists packages and their FluentCMS dependencies; done means no listed package has an unlisted FluentCMS dependency, and release notes explain using --admin false until A-47.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:admin area:build type:bug

Problem

The Publish workflow keeps the admin out of a release by removing FluentCMS.Admin*.nupkg and .snupkg after the pack (.github/workflows/publish.yml, lines 205 to 208). The pattern does not match FluentCMS.Plugins.Media.Admin, which is packable (admin/src/plugins/FluentCMS.Plugins.Media.Admin/FluentCMS.Plugins.Media.Admin.csproj) and depends on FluentCMS.Admin.Abstractions and FluentCMS.Admin.Components, both removed. A6 adds five more halves of the same name shape. FluentCMS.Templates is pushed too, and dotnet new fluentcms-plugin writes an admin half by default that references the same two packages (templates/fluentcms-plugin/src/FluentCms-Plugin1.Admin/FluentCms-Plugin1.Admin.csproj). 1.0.0-preview.1 was tagged on 16 Nov 2026, before the media half and the template's half existed, so no release has met this. A release cut from main today would push a package that cannot be restored and a template whose default output does not restore from nuget.org. Read from the workflow file; no dry run was made to see the list.

Proposal

Until A-47: remove FluentCMS.Plugins.*.Admin as well, and say in the notes of a release that dotnet new fluentcms-plugin takes --admin false until the admin is released; or have the dry run fail when a package to push depends on a FluentCMS package that is not among them.

Acceptance

  • A dry run lists no package that depends on a FluentCMS package it does not list
  • The notes of a release before A-47 say how to use the plugin template

Found while A7 was planned (20 Nov 2026). Matters only if a release is tagged before A-47. Size: S.

Lingua principale
C#
Stelle
567
Fork
107
Merge medio
1h 19m
PR unite (30g)
353

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di fluentcms/FluentCMS

Tutte le issue di fluentcms/FluentCMS

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.