🐛 [firebase_ui_firestore] FirestoreDataTable need polishing to only query the right amount of data

Offen
  • Stimmt etwas nicht?
#11 4 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

Maintainer antworten meist innerhalb von 6 Tagen

@rrousselGit arbeitet bereits daran.

Seit 03.10.2023.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Beschreibung

enhancement firestore Keep Open

Bug report

Describe the bug
After the code(bellow) the first item is more an discussion than a bub, but the point 2 and 3 seems to be bugs.

@override
  Widget build(BuildContext context) {
    return StreamBuilder(
      stream: _query.snapshots(),
      builder: (context, snapshot) {
        return AggregateQueryBuilder(
          query: _query.count(),
          builder: (context, aggSsnapshot) {
            return FirestoreQueryBuilder<Map<String, Object?>>(
              query: _query,
              builder: (context, snapshot, child) {
                if (aggSsnapshot.hasData) {
                  source.setFromSnapshot(snapshot, aggSsnapshot.requireData);
                } else {
                  source.setFromSnapshot(snapshot);
                }

                return AnimatedBuilder(
                  animation: source,
                  builder: (context, child) {
                    final actions = [
                      ...?widget.actions,
                      if (widget.canDeleteItems &&
                          source._selectedRowIds.isNotEmpty)
                        IconButton(
                          icon: const Icon(Icons.delete),
                          onPressed: source.onDeleteSelectedItems,
                        ),
                    ];
                    return PaginatedDataTable(
                      source: source,
                      onSelectAll: selectionEnabled ? source.onSelectAll : null,
                      onPageChanged: widget.onPageChanged,
                      showCheckboxColumn: widget.showCheckboxColumn,
                      arrowHeadColor: widget.arrowHeadColor,
                      checkboxHorizontalMargin: widget.checkboxHorizontalMargin,
                      columnSpacing: widget.columnSpacing,
                      dataRowMaxHeight: widget.dataRowMaxHeight,
                      dataRowMinHeight: widget.dataRowMinHeight,
                      dragStartBehavior: widget.dragStartBehavior,
                      headingRowHeight: widget.headingRowHeight,
                      horizontalMargin: widget.horizontalMargin,
                      rowsPerPage: widget.rowsPerPage,
                      showFirstLastButtons: widget.showFirstLastButtons,
                      sortAscending: widget.sortAscending,
                      sortColumnIndex: widget.sortColumnIndex,
                      header: actions.isEmpty
                          ? null
                          : (widget.header ?? const SizedBox()),
                      actions: actions.isEmpty ? null : actions,
                      columns: [
                        for (final head in widget.columnLabels.values)
                          DataColumn(label: head)
                      ],
                    );
                  },
                );
              },
            );
          },
        );
      },
    );
  }

Couple os things:

  1. Do we really want StreamBuilder at the first place?
    Seems it only needed to make sure the AggregateQueryBuilder will return the right number of rows, if the data is changing on the query side....but this defeat the intent of limiting the data retrieved, we even make an extra query when we can use the docs.lenght to update the PaginatedDataTable bottom navigation information.

  2. I think the we need to pass to the FirestoreQueryBuilder to limit the snapshot to the number of rows we have in the page => pageSize: widget.rowsPerPage, otherwise if you allow the checkbox and select all items on the page (with let say 10 rows) you will get 20 item selected !!!

  3. With the addition of the _aggregateSnapshot I think the override of : bool get isRowCountApproximate => _aggregateSnapshot?.count == null || (_previousSnapshot!.isFetching || _previousSnapshot!.hasMore);

maybe not right, because the intent of having AggregateQueryBuilder seems to have the exact number of rows, so the isRowCountApproximate can be always false. But we can argue the query can send more rows the next time tap on the next page...

Vorherrschende Sprache
Dart
Sterne
152
Forks
144
Ø Merge
17 Std. 49 Min.
Gemergte PRs (30 T.)
3

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus firebase/FirebaseUI-Flutter

Alle Issues in firebase/FirebaseUI-Flutter

Ähnliche Issues

Weitere Issues zu Dart

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.