Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

🐛 [firebase_ui_firestore] FirestoreDataTable need polishing to only query the right amount of data

未关闭
  • 哪里不对？
#11 4 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 2 天内回复

@rrousselGit 已经在做这个了。

开始于 2023年10月3日。

评估

这个 Issue 还没有评估数据。

描述

enhancement firestore Keep Open

Bug report

Describe the bug
After the code(bellow) the first item is more an discussion than a bub, but the point 2 and 3 seems to be bugs.

@override
  Widget build(BuildContext context) {
    return StreamBuilder(
      stream: _query.snapshots(),
      builder: (context, snapshot) {
        return AggregateQueryBuilder(
          query: _query.count(),
          builder: (context, aggSsnapshot) {
            return FirestoreQueryBuilder<Map<String, Object?>>(
              query: _query,
              builder: (context, snapshot, child) {
                if (aggSsnapshot.hasData) {
                  source.setFromSnapshot(snapshot, aggSsnapshot.requireData);
                } else {
                  source.setFromSnapshot(snapshot);
                }

                return AnimatedBuilder(
                  animation: source,
                  builder: (context, child) {
                    final actions = [
                      ...?widget.actions,
                      if (widget.canDeleteItems &&
                          source._selectedRowIds.isNotEmpty)
                        IconButton(
                          icon: const Icon(Icons.delete),
                          onPressed: source.onDeleteSelectedItems,
                        ),
                    ];
                    return PaginatedDataTable(
                      source: source,
                      onSelectAll: selectionEnabled ? source.onSelectAll : null,
                      onPageChanged: widget.onPageChanged,
                      showCheckboxColumn: widget.showCheckboxColumn,
                      arrowHeadColor: widget.arrowHeadColor,
                      checkboxHorizontalMargin: widget.checkboxHorizontalMargin,
                      columnSpacing: widget.columnSpacing,
                      dataRowMaxHeight: widget.dataRowMaxHeight,
                      dataRowMinHeight: widget.dataRowMinHeight,
                      dragStartBehavior: widget.dragStartBehavior,
                      headingRowHeight: widget.headingRowHeight,
                      horizontalMargin: widget.horizontalMargin,
                      rowsPerPage: widget.rowsPerPage,
                      showFirstLastButtons: widget.showFirstLastButtons,
                      sortAscending: widget.sortAscending,
                      sortColumnIndex: widget.sortColumnIndex,
                      header: actions.isEmpty
                          ? null
                          : (widget.header ?? const SizedBox()),
                      actions: actions.isEmpty ? null : actions,
                      columns: [
                        for (final head in widget.columnLabels.values)
                          DataColumn(label: head)
                      ],
                    );
                  },
                );
              },
            );
          },
        );
      },
    );
  }

Couple os things:

  1. Do we really want StreamBuilder at the first place?
    Seems it only needed to make sure the AggregateQueryBuilder will return the right number of rows, if the data is changing on the query side....but this defeat the intent of limiting the data retrieved, we even make an extra query when we can use the docs.lenght to update the PaginatedDataTable bottom navigation information.

  2. I think the we need to pass to the FirestoreQueryBuilder to limit the snapshot to the number of rows we have in the page => pageSize: widget.rowsPerPage, otherwise if you allow the checkbox and select all items on the page (with let say 10 rows) you will get 20 item selected !!!

  3. With the addition of the _aggregateSnapshot I think the override of : bool get isRowCountApproximate => _aggregateSnapshot?.count == null || (_previousSnapshot!.isFetching || _previousSnapshot!.hasMore);

maybe not right, because the intent of having AggregateQueryBuilder seems to have the exact number of rows, so the isRowCountApproximate can be always false. But we can argue the query can send more rows the next time tap on the next page...

主要语言
Dart
星标
152
派生
142
平均合并
2 天 54 分钟
30 天内合并 PR
11

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

firebase/FirebaseUI-Flutter 的其他 Issue

查看 firebase/FirebaseUI-Flutter 的全部 Issue

相似的 Issue

更多 Dart Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。