alpha.26 UI: Light theme in app windows, Assistant logo, numbered lists, Wallet sidebar Connect

Offen
  • Stimmt etwas nicht?
#511 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
25/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
javascript, markdown, rust
Bereich
desktop, frontend, testing

Rechercherichtung

Start with the UI and Assistant formatter code for the five numbered findings, then inspect the existing theme and list tests; the payload does not name their paths. Reproduce the Markdown table freeze and the theme, logo, list, and Wallet sidebar issues in a browser, then run the relevant tests. Done means all five cases work in the new alpha in Light and Dark themes, with tests that fail on the old code. The issue says candidate work is already underway and installed canary qualification belongs to #93.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

A tester checked four reports on the signed canary 0.8.0-alpha.26 (source 8a74b669c) in a headless browser. OMP then checked each one in the source. All four are real, and the check found a fifth problem (item 5). None of them is new in alpha.26: 0.7.1 has the same code. On 30 Oct Anders decided that the fixes go into a new alpha before the stable release.

  1. Light theme in app windows. In Light theme, Library, Archive, Documents and Marketplace open dark. People and Wallet turn dark after their window reloads. Cause: apps start dark and change only when Home sends them the theme. Home sent it when the theme changed, but not when an app window loaded. Fix: Home sends the current theme and accent colour to each app window when it loads.

  2. Assistant logo. The ELASTOS lettering in the Assistant header is white, so it cannot be seen in Light theme. Fix: in Light theme the Assistant uses the navy logo, as the Home toolbar already does.

  3. Numbered lists in Assistant replies. A list shows "1. 1. 1." when its items have blank lines or text between them, and sub-bullets get numbers. Cause: the reply formatter starts a new list for each block and drops the number. Fix: one list continues across blank lines and text under an item, keeps its first number, and puts sub-bullets in a nested list.

  4. Wallet Connect from the sidebar. With the Wallet open in the sidebar, Connect for MetaMask or UniSat does nothing. Cause: while the sidebar is open, Home tries to show the connector in a panel that does not exist in the page, and ignores the failure. Fix: Connect closes the sidebar and opens the connector window, as it does from the full Wallet window. The unused panel code is removed; the security checks on the connector stay.

  5. Assistant freezes on a table (found during this check). A reply that contains a Markdown table, or any line with a | character, makes the Assistant's formatter loop forever, so the Assistant stops responding when such a chat is shown again. Two separate checks reproduced it on 8a74b669c; 0.7.1 has the same broken pattern. Cause: the pattern that should recognise a table's |---| line never matches, and the paragraph step then reads no line, so the loop never moves on. Fix: correct the pattern, and make each paragraph read at least one line. Tables now show as tables.

Done means: each case works on the new alpha installed from the canary, in Light and Dark theme, checked in a real browser; the list and theme changes have tests that fail on the old code.

Outside the list fix: Documents has its own formatter with the same missing list number. Live Assistant streaming deliberately stays plain text. A completed reply that remains raw Markdown until the chat is reopened is a separate completion defect, included in the new candidate scope. Its reviewed local fix is integrated in the rc.1 candidate. Codex took over OMP on 30 October; local candidate e15c77c9200e1f750fa8646de1bdbd160ce9e2f8 also repairs wallpaper token renewal. Seven authority tests, the wallpaper browser fixture and independent repair review pass. Installed canary acceptance remains open; #93 owns qualification.

Work branch: fix/a26-ui-findings (draft PR follows after review).

Vorherrschende Sprache
Rust
Sterne
6
Forks
2
Ø Merge
1 T. 3 Std.
Gemergte PRs (30 T.)
42

Entwicklungsumgebung

Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus elastos/elastos-runtime

Alle Issues in elastos/elastos-runtime

Ähnliche Issues

Weitere Issues zu Rust

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.