alpha.26 UI: Light theme in app windows, Assistant logo, numbered lists, Wallet sidebar Connect

オープン
#511 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
25/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
停滞
技術スタック
javascript, markdown, rust

調査の方向性

Start with the UI and Assistant formatter code for the five numbered findings, then inspect the existing theme and list tests; the payload does not name their paths. Reproduce the Markdown table freeze and the theme, logo, list, and Wallet sidebar issues in a browser, then run the relevant tests. Done means all five cases work in the new alpha in Light and Dark themes, with tests that fail on the old code. The issue says candidate work is already underway and installed canary qualification belongs to #93.

索引モデルが issue の本文から書いたものです。

説明

A tester checked four reports on the signed canary 0.8.0-alpha.26 (source 8a74b669c) in a headless browser. OMP then checked each one in the source. All four are real, and the check found a fifth problem (item 5). None of them is new in alpha.26: 0.7.1 has the same code. On 30 Oct Anders decided that the fixes go into a new alpha before the stable release.

  1. Light theme in app windows. In Light theme, Library, Archive, Documents and Marketplace open dark. People and Wallet turn dark after their window reloads. Cause: apps start dark and change only when Home sends them the theme. Home sent it when the theme changed, but not when an app window loaded. Fix: Home sends the current theme and accent colour to each app window when it loads.

  2. Assistant logo. The ELASTOS lettering in the Assistant header is white, so it cannot be seen in Light theme. Fix: in Light theme the Assistant uses the navy logo, as the Home toolbar already does.

  3. Numbered lists in Assistant replies. A list shows "1. 1. 1." when its items have blank lines or text between them, and sub-bullets get numbers. Cause: the reply formatter starts a new list for each block and drops the number. Fix: one list continues across blank lines and text under an item, keeps its first number, and puts sub-bullets in a nested list.

  4. Wallet Connect from the sidebar. With the Wallet open in the sidebar, Connect for MetaMask or UniSat does nothing. Cause: while the sidebar is open, Home tries to show the connector in a panel that does not exist in the page, and ignores the failure. Fix: Connect closes the sidebar and opens the connector window, as it does from the full Wallet window. The unused panel code is removed; the security checks on the connector stay.

  5. Assistant freezes on a table (found during this check). A reply that contains a Markdown table, or any line with a | character, makes the Assistant's formatter loop forever, so the Assistant stops responding when such a chat is shown again. Two separate checks reproduced it on 8a74b669c; 0.7.1 has the same broken pattern. Cause: the pattern that should recognise a table's |---| line never matches, and the paragraph step then reads no line, so the loop never moves on. Fix: correct the pattern, and make each paragraph read at least one line. Tables now show as tables.

Done means: each case works on the new alpha installed from the canary, in Light and Dark theme, checked in a real browser; the list and theme changes have tests that fail on the old code.

Outside the list fix: Documents has its own formatter with the same missing list number. Live Assistant streaming deliberately stays plain text. A completed reply that remains raw Markdown until the chat is reopened is a separate completion defect, included in the new candidate scope. Its reviewed local fix is integrated in the rc.1 candidate. Codex took over OMP on 30 October; local candidate e15c77c9200e1f750fa8646de1bdbd160ce9e2f8 also repairs wallpaper token renewal. Seven authority tests, the wallpaper browser fixture and independent repair review pass. Installed canary acceptance remains open; #93 owns qualification.

Work branch: fix/a26-ui-findings (draft PR follows after review).

主要言語
Rust
スター
6
フォーク
2
平均マージ
1日 3時間
マージ済み PR(30日)
42

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

elastos/elastos-runtime のほかの issue

elastos/elastos-runtime の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。