[BUG] up: an optional (required: false) service_healthy dependent is not started when a required dependent shares the failing wait

Offen
#14,507 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@ndeloof arbeitet bereits daran.

Seit 16.11.2026.

  • #14508 von @ndeloof — offen

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
58/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
docker-compose, go
Bereich
backend, devops

Rechercherichtung

Start by tracing how the start phase handles the shared service_healthy wait and how abortReason decides whether each dependent is blocked; the issue points to the plan engine change in #14081 and a possible connection to #14311. Reproduce with the supplied compose file and up -d db needs_db optional_db, then compare with a run that leaves out needs_db. Done when the required dependent fails while optional_db starts with the optional dependency warning.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Description

With v5.7.1, up does not start a service whose service_healthy dependency is optional (required: false) when another service in the same run depends on that dependency as required and the dependency turns unhealthy. The optional dependent is given up together with the required one, with the event:

not started: condition "service_healthy" of service "db" not met

When the required dependent is not part of the run, the same optional dependent is started as expected (with the optional dependency "db" failed to start warning). So whether an optional dependent starts depends on whether some other service needs the same dependency as required.

v5.6.0 starts the optional dependent in both cases.

Steps to reproduce

A compose file along these lines (a dependency whose healthcheck always fails, one required and one optional service_healthy dependent):

services:
  db:
    image: busybox
    command: sleep infinity
    healthcheck:
      test: ["CMD-SHELL", "exit 1"]
      interval: 2s
      timeout: 3s
      retries: 1

  needs_db:
    image: busybox
    command: sleep infinity
    depends_on:
      db:
        condition: service_healthy

  optional_db:
    image: busybox
    command: sleep infinity
    depends_on:
      db:
        condition: service_healthy
        required: false

Then up -d db needs_db optional_db.

Expected

needs_db fails (its required condition is not met); optional_db is started anyway, with the optional-dependency warning, as v5.6.0 does:

Container db Error dependency db failed to start
Container db Skipped: optional dependency "db" failed to start
level=warning msg="optional dependency \"db\" failed to start: container db is unhealthy"
Container optional_db Started
dependency failed to start: container db is unhealthy
Actual (v5.7.1)

optional_db is not started; its row gets not started: condition "service_healthy" of service "db" not met. With needs_db left out of the run, optional_db starts.

Notes

From reading the code, the service_healthy wait on db looks like a single plan node shared by both dependents. When it fails (with required semantics, for needs_db), it cancels the phase, and abortReason reports optional_db as held by "the very wait that failed" (unmetCondition(...) + " not met"), although for optional_db that wait should not block its start. This seems to have come with the start phase moving into the plan engine (#14081). Possibly related to #14311 (start -p treating an optional dependency as required).

Versions
  • Seen with the Go SDK github.com/docker/compose/v5 v5.7.1, calling Up (the reproduction above was run through an application embedding it, with real images rather than busybox; the file above is the minimal equivalent).
  • The docker compose CLI v5.6.0 on the same host and project starts the optional dependent.
  • Not tried with the v5.7.1 CLI binary.
  • Docker Engine on Linux.
Vorherrschende Sprache
Go
Sterne
38.9k
Forks
6k
Ø Merge
2 T. 22 Std.
Gemergte PRs (30 T.)
81

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus docker/compose

Alle Issues in docker/compose

Ähnliche Issues

Weitere Issues zu Go

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.