[BUG] up: an optional (required: false) service_healthy dependent is not started when a required dependent shares the failing wait
Les mainteneurs répondent en général sous 1 jour
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 58/100
Piste de recherche
Start by tracing how the start phase handles the shared service_healthy wait and how abortReason decides whether each dependent is blocked; the issue points to the plan engine change in #14081 and a possible connection to #14311. Reproduce with the supplied compose file and up -d db needs_db optional_db, then compare with a run that leaves out needs_db. Done when the required dependent fails while optional_db starts with the optional dependency warning.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Description
With v5.7.1, up does not start a service whose service_healthy dependency is optional (required: false) when another service in the same run depends on that dependency as required and the dependency turns unhealthy. The optional dependent is given up together with the required one, with the event:
not started: condition "service_healthy" of service "db" not met
When the required dependent is not part of the run, the same optional dependent is started as expected (with the optional dependency "db" failed to start warning). So whether an optional dependent starts depends on whether some other service needs the same dependency as required.
v5.6.0 starts the optional dependent in both cases.
Steps to reproduce
A compose file along these lines (a dependency whose healthcheck always fails, one required and one optional service_healthy dependent):
services:
db:
image: busybox
command: sleep infinity
healthcheck:
test: ["CMD-SHELL", "exit 1"]
interval: 2s
timeout: 3s
retries: 1
needs_db:
image: busybox
command: sleep infinity
depends_on:
db:
condition: service_healthy
optional_db:
image: busybox
command: sleep infinity
depends_on:
db:
condition: service_healthy
required: false
Then up -d db needs_db optional_db.
Expected
needs_db fails (its required condition is not met); optional_db is started anyway, with the optional-dependency warning, as v5.6.0 does:
Container db Error dependency db failed to start
Container db Skipped: optional dependency "db" failed to start
level=warning msg="optional dependency \"db\" failed to start: container db is unhealthy"
Container optional_db Started
dependency failed to start: container db is unhealthy
Actual (v5.7.1)
optional_db is not started; its row gets not started: condition "service_healthy" of service "db" not met. With needs_db left out of the run, optional_db starts.
Notes
From reading the code, the service_healthy wait on db looks like a single plan node shared by both dependents. When it fails (with required semantics, for needs_db), it cancels the phase, and abortReason reports optional_db as held by "the very wait that failed" (unmetCondition(...) + " not met"), although for optional_db that wait should not block its start. This seems to have come with the start phase moving into the plan engine (#14081). Possibly related to #14311 (start -p treating an optional dependency as required).
Versions
- Seen with the Go SDK
github.com/docker/compose/v5v5.7.1, callingUp(the reproduction above was run through an application embedding it, with real images rather than busybox; the file above is the minimal equivalent). - The
docker composeCLI v5.6.0 on the same host and project starts the optional dependent. - Not tried with the v5.7.1 CLI binary.
- Docker Engine on Linux.
- Langage dominant
- Go
- Étoiles
- 38.9k
- Forks
- 6k
- Merge moyen
- 2 j 22 h
- PR mergées (30 j)
- 81
Préparer son environnement
- Fournit un Dockerfile ou un fichier Docker Compose
- Propose un modèle de pull request
- Lire le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de docker/compose
-
[BUG] `docker compose port` prints `:0` (exit 0) for a port the image exposes but the service does not publishPeut-être pris @ndeloof l’a pris il y a 1 jour. Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 62/100
docker/compose#14435 · 2 commentaires ·
Les mainteneurs répondent en général sous 1 jour
-
[BUG] deploy.restart_policy without condition drops the restart policyPeut-être à nouveau libre @akshat-lakhera l’a pris il y a 25 jours, et aucune pull request n’est ouverte. Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 82/100
docker/compose#14383 · 3 commentaires ·
Les mainteneurs répondent en général sous 1 jour
-
[BUG] Negative replica count in scale flags (docker compose scale / --scale) is accepted without validationPeut-être pris @arsalanyavari l’a pris il y a 8 jours. Ouvertekind/bug status/approved
Difficulté 2/5 1-3 heures Accessibilité débutants 30/100
Les mainteneurs répondent en général sous 1 jour
-
[BUG] pre_stop hooks are skipped when up or scale stops a containerPeut-être pris @htoyoda18 l’a pris il y a 11 jours. Ouvertekind/bug status/approved
Difficulté 4/5 3-5 jours Accessibilité débutants 53/100
Les mainteneurs répondent en général sous 1 jour
Toutes les issues de docker/compose
Issues similaires
-
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
IBM-Cloud/terraform-provider-ibm#7115 ·
Les mainteneurs répondent en général sous 2 jours
-
Difficulté 2/5 1-3 heures Accessibilité débutants 86/100
fluxcd/notification-controller#1441 ·
Les mainteneurs répondent en général sous 1 jour
-
bug
Difficulté 2/5 1-3 heures Accessibilité débutants 66/100
volcengine/volcengine-go-sdk#163 · 1 commentaire ·
-
Difficulté 2/5 1-3 heures Accessibilité débutants 76/100
OneBusAway/maglev#2145 ·
Les mainteneurs répondent en général sous 2 jours
-
priority/medium status/ready type/chore
Difficulté 2/5 1-3 heures Accessibilité débutants 84/100
discobox-ai/discobox#1357 ·
Les mainteneurs répondent en général sous 1 jour