`signIn.sso()` (Future API) silently does nothing for OAuth when a SignIn already exists
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Anfängerfreundlichkeit
- 58/100
- Issue-Typ
- Bug
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- next.js, react, typescript
- Bereich
- authentication, frontend
Rechercherichtung
Start in packages/clerk-js/src/core/resources/SignIn.ts and read SignInFuture.sso, focusing on how shouldCreateSignIn handles an existing sign-in for OAuth strategies. Reproduce with the component and steps in the issue, then verify that sso() starts OAuth or returns a meaningful error when a sign-in already has an id. The issue does not name a test file.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Preliminary Checks
- I have reviewed the documentation: https://clerk.com/docs
- I have searched for existing issues: https://github.com/clerk/javascript/issues
- I have not already reached out to Clerk support via email or Discord (if you have, no need to open an issue here)
- This issue is not a question, general help request, or anything other than a bug report directly related to Clerk.
Reproduction
No public repository. Minimal component below (Next.js App Router, Future API). Happy to put together a repo if that helps.
Publishable key
Development instance, available on request.
Description
Related to #9006, but the trigger is different: no reset() is involved, and the button stays inert across page reloads.
With the Future API (useSignIn() from @clerk/nextjs, not /legacy), signIn.sso({ strategy: 'oauth_google', ... }) resolves with { error: null } without sending any request and without navigating, as soon as the client already holds a SignIn that has an id and no pending external redirect. A failed attempt with an unknown identifier is enough to get there. Since that sign-in lives on the client, it survives page reloads: "Continue with Google" stays dead for that browser until the sign-in goes away.
Steps to reproduce:
'use client';
import { useSignIn } from '@clerk/nextjs';
export default function Page() {
const { signIn } = useSignIn();
return (
<>
<button onClick={() => signIn?.create({ identifier: '[email protected]' })}>
1. Attempt with an unknown identifier
</button>
<button
onClick={async () => {
const { error } = await signIn!.sso({
strategy: 'oauth_google',
redirectUrl: '/',
redirectCallbackUrl: `${window.location.origin}/sso-callback`,
});
console.log('sso resolved', { error, id: signIn!.id, status: signIn!.status });
}}
>
2. Continue with Google
</button>
</>
);
}
- Click 1. The attempt fails with
form_identifier_not_found, and the client now holds aSignIn(sia_…) with statusneeds_identifier. In our app we first ran into it after a failedsignIn.password(). - Click 2.
- Optionally reload the page and click 2 again: same result.
Expected behavior:
sso() starts a new OAuth attempt and navigates to the provider, or at least resolves with an error saying why it can't.
Actual behavior:
sso() resolves with { error: null }. No request is sent to the Frontend API, nothing navigates, and signIn.id is unchanged.
Root cause (clerk-js 6.41.0, unchanged on main / 6.42.3), in SignInFuture.sso (packages/clerk-js/src/core/resources/SignIn.ts):
const hasPendingRedirect = !!this.#resource.firstFactorVerification.externalVerificationRedirectURL;
const wouldReplayStaleRedirect = strategy !== 'enterprise_sso' && hasPendingRedirect;
const shouldCreateSignIn = !this.#resource.id || wouldReplayStaleRedirect;
When the sign-in already has an id and no external redirect URL, shouldCreateSignIn is false. For oauth_* strategies nothing else runs afterwards (prepare_first_factor is only called for enterprise_sso), so pendingHandOff() returns null and the method returns without doing anything. The classic authenticateWithRedirect doesn't have this problem, since it creates a new sign-in unless continueSignIn is set.
Workaround without internals: when signIn.id is set, call signIn.reset(), then call sso() from an effect on the fresh signIn the hook returns on the next render. In 6.41.0 the reset does reach the hook on the next render; it just can't be used inside the same handler, which is #9006.
Possible fixes:
- create a new sign-in for
oauth_*strategies when reusing the existing one would not produce a redirect, or - resolve with an
errorinstead of a silent no-op.
Environment
@clerk/nextjs: 7.3.2
@clerk/react: 6.6.1
@clerk/shared: 4.10.1
@clerk/clerk-js: 6.41.0 (loaded from the Frontend API)
next: 15.5.18
react: 18.2.0
OS: macOS; browser: Chromium-based
- Vorherrschende Sprache
- TypeScript
- Sterne
- 1.8k
- Forks
- 492
- Ø Merge
- 1 T. 8 Std.
- Gemergte PRs (30 T.)
- 374
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus clerk/javascript
-
<SignIn />: the reset password code step renders an empty, focusable back button with no accessible nameEvtl. vergeben Ein verknüpfter Pull Request ist offen oder bereits gemergt. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 85/100
clerk/javascript#10708 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Built-in reverification dialog lacks an accessible name (aria-dialog-name)Evtl. vergeben @ItsShivam05 hat das vor 5 Tagen übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
clerk/javascript#10548 ·
Maintainer antworten meist innerhalb von 1 Tag
-
MFA enrollment QR SVG lacks an accessible name (svg-img-alt)Evtl. vergeben Ein verknüpfter Pull Request ist offen oder bereits gemergt. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 84/100
clerk/javascript#10547 ·
Maintainer antworten meist innerhalb von 1 Tag
-
<SignIn />: first "Use email" click switches back to phone when `initialValues.phoneNumber` is setEvtl. vergeben @twicestruck hat das vor 22 Tagen übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 74/100
clerk/javascript#10487 ·
Maintainer antworten meist innerhalb von 1 Tag
-
useLoadedIsomorphicClerk misses "ready" when a ClerkProvider remounts after clerk-js has loaded — <ClerkLoading> never resolvesEvtl. wieder frei Ein Pull Request dazu wurde ohne Merge geschlossen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
clerk/javascript#10462 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in clerk/javascript
Ähnliche Issues
-
`@angular/[email protected]` depends on vulnerable Vite 7.3.7 - GHSA-p4f5-76q4-ffq7 (Critical RCE)Offenarea: @angular/build
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
angular/angular-cli#34764 ·
Maintainer antworten meist innerhalb von 1 Tag
-
status/need-triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
google-gemini/gemini-cli#30384 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
P2
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 84/100
Maintainer antworten meist innerhalb von 1 Tag
-
bug ready-for-human
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 60/100
LucasSantana-Dev/Lucky#3150 ·
Maintainer antworten meist innerhalb von 1 Tag
-
enhancement good first issue priority: low size: XS
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 88/100
Maintainer antworten meist innerhalb von 1 Tag