`signIn.sso()` (Future API) silently does nothing for OAuth when a SignIn already exists

Đang mở
#10,709 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
3/5
Thời gian dự kiến
1-2 ngày
Mức phù hợp với người mới
58/100
Loại issue
Lỗi
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Lĩnh vực
authentication, frontend

Hướng nghiên cứu

Start in packages/clerk-js/src/core/resources/SignIn.ts and read SignInFuture.sso, focusing on how shouldCreateSignIn handles an existing sign-in for OAuth strategies. Reproduce with the component and steps in the issue, then verify that sso() starts OAuth or returns a meaningful error when a sign-in already has an id. The issue does not name a test file.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Preliminary Checks
  • I have reviewed the documentation: https://clerk.com/docs
  • I have searched for existing issues: https://github.com/clerk/javascript/issues
  • I have not already reached out to Clerk support via email or Discord (if you have, no need to open an issue here)
  • This issue is not a question, general help request, or anything other than a bug report directly related to Clerk.
Reproduction

No public repository. Minimal component below (Next.js App Router, Future API). Happy to put together a repo if that helps.

Publishable key

Development instance, available on request.

Description

Related to #9006, but the trigger is different: no reset() is involved, and the button stays inert across page reloads.

With the Future API (useSignIn() from @clerk/nextjs, not /legacy), signIn.sso({ strategy: 'oauth_google', ... }) resolves with { error: null } without sending any request and without navigating, as soon as the client already holds a SignIn that has an id and no pending external redirect. A failed attempt with an unknown identifier is enough to get there. Since that sign-in lives on the client, it survives page reloads: "Continue with Google" stays dead for that browser until the sign-in goes away.

Steps to reproduce:

'use client';
import { useSignIn } from '@clerk/nextjs';

export default function Page() {
  const { signIn } = useSignIn();
  return (
    <>
      <button onClick={() => signIn?.create({ identifier: '[email protected]' })}>
        1. Attempt with an unknown identifier
      </button>
      <button
        onClick={async () => {
          const { error } = await signIn!.sso({
            strategy: 'oauth_google',
            redirectUrl: '/',
            redirectCallbackUrl: `${window.location.origin}/sso-callback`,
          });
          console.log('sso resolved', { error, id: signIn!.id, status: signIn!.status });
        }}
      >
        2. Continue with Google
      </button>
    </>
  );
}
  1. Click 1. The attempt fails with form_identifier_not_found, and the client now holds a SignIn (sia_…) with status needs_identifier. In our app we first ran into it after a failed signIn.password().
  2. Click 2.
  3. Optionally reload the page and click 2 again: same result.

Expected behavior:

sso() starts a new OAuth attempt and navigates to the provider, or at least resolves with an error saying why it can't.

Actual behavior:

sso() resolves with { error: null }. No request is sent to the Frontend API, nothing navigates, and signIn.id is unchanged.

Root cause (clerk-js 6.41.0, unchanged on main / 6.42.3), in SignInFuture.sso (packages/clerk-js/src/core/resources/SignIn.ts):

const hasPendingRedirect = !!this.#resource.firstFactorVerification.externalVerificationRedirectURL;
const wouldReplayStaleRedirect = strategy !== 'enterprise_sso' && hasPendingRedirect;
const shouldCreateSignIn = !this.#resource.id || wouldReplayStaleRedirect;

When the sign-in already has an id and no external redirect URL, shouldCreateSignIn is false. For oauth_* strategies nothing else runs afterwards (prepare_first_factor is only called for enterprise_sso), so pendingHandOff() returns null and the method returns without doing anything. The classic authenticateWithRedirect doesn't have this problem, since it creates a new sign-in unless continueSignIn is set.

Workaround without internals: when signIn.id is set, call signIn.reset(), then call sso() from an effect on the fresh signIn the hook returns on the next render. In 6.41.0 the reset does reach the hook on the next render; it just can't be used inside the same handler, which is #9006.

Possible fixes:

  • create a new sign-in for oauth_* strategies when reusing the existing one would not produce a redirect, or
  • resolve with an error instead of a silent no-op.
Environment
@clerk/nextjs: 7.3.2
@clerk/react: 6.6.1
@clerk/shared: 4.10.1
@clerk/clerk-js: 6.41.0 (loaded from the Frontend API)
next: 15.5.18
react: 18.2.0
OS: macOS; browser: Chromium-based
Ngôn ngữ chính
TypeScript
Star
1.8k
Fork
492
Merge trung bình
1 ngày 8 giờ
Pull request đã merge (30 ngày)
374

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của clerk/javascript

Tất cả issue của clerk/javascript

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.