Trace: a rename inside an amend or a squash loses the AI line attribution

Offen
  • Stimmt etwas nicht?
#3,686 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
55/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
git, go
Bereich
backend, devtools

Rechercherichtung

Start by reading spec issue-3639 R-007 and the Trace README changes and tests in PR #3685; then trace how the push path matches file lines against the session ledger. Reproduce the amend-with-rename flow from the issue and compare it with the separate-rename and amend-only cases. Done means the amended commit is listed as session evidence and hello.txt retains 3 AI lines and 0 human lines, with coverage for the squash case.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

bug chainloop component/CLI

A rename inside an amend or a squash of a session commit loses the AI line attribution. All the lines of the renamed file count as human.

Spec issue-3639 R-007 says: "Attribution MUST survive a file rename, amend, rebase, squash, and cherry-pick in the same clone. The CLI MUST match lines by content."

Steps to reproduce

  1. On a feature branch, an agent session writes greeting.txt with three lines, commits it, and pushes.
  2. A human runs git mv greeting.txt hello.txt, then git commit --amend --no-edit, then git push --force.

Expected

The stored session evidence lists the amended commit, and hello.txt has 3 AI lines and 0 human lines.

Actual

The evidence lists the amended commit, but hello.txt has 0 AI lines and 3 human lines.

Cause

The amended commit has no parent that holds greeting.txt, so git sees no rename: the commit creates hello.txt. The ledger of the session holds the line fingerprints under greeting.txt only. The push matches the lines of a file against the ledger of the same path and of the old paths of a rename, so no line of hello.txt matches. A squash that folds a rename into the session commit has the same result.

A rename in a separate commit keeps the AI lines, and an amend with no rename keeps them too.

Evidence

The end-to-end suite found this (spec issue-3635). The first version of the Renames and rewrites check in #3685 used this flow. #3685 documents the gap in the Trace README and tests the amend and the rename separately.

Vorherrschende Sprache
Go
Sterne
582
Forks
61
Ø Merge
12 Std. 47 Min.
Gemergte PRs (30 T.)
137

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus chainloop-dev/chainloop

Alle Issues in chainloop-dev/chainloop

Ähnliche Issues

Weitere Issues zu Go

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.