Trace: a rename inside an amend or a squash loses the AI line attribution

未关闭
#3,686 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
1-2 天
新手友好度
55/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
git, go
领域
backend, devtools

调研方向

Start by reading spec issue-3639 R-007 and the Trace README changes and tests in PR #3685; then trace how the push path matches file lines against the session ledger. Reproduce the amend-with-rename flow from the issue and compare it with the separate-rename and amend-only cases. Done means the amended commit is listed as session evidence and hello.txt retains 3 AI lines and 0 human lines, with coverage for the squash case.

由索引模型根据 Issue 内容生成。

描述

bug chainloop component/CLI

A rename inside an amend or a squash of a session commit loses the AI line attribution. All the lines of the renamed file count as human.

Spec issue-3639 R-007 says: "Attribution MUST survive a file rename, amend, rebase, squash, and cherry-pick in the same clone. The CLI MUST match lines by content."

Steps to reproduce

  1. On a feature branch, an agent session writes greeting.txt with three lines, commits it, and pushes.
  2. A human runs git mv greeting.txt hello.txt, then git commit --amend --no-edit, then git push --force.

Expected

The stored session evidence lists the amended commit, and hello.txt has 3 AI lines and 0 human lines.

Actual

The evidence lists the amended commit, but hello.txt has 0 AI lines and 3 human lines.

Cause

The amended commit has no parent that holds greeting.txt, so git sees no rename: the commit creates hello.txt. The ledger of the session holds the line fingerprints under greeting.txt only. The push matches the lines of a file against the ledger of the same path and of the old paths of a rename, so no line of hello.txt matches. A squash that folds a rename into the session commit has the same result.

A rename in a separate commit keeps the AI lines, and an amend with no rename keeps them too.

Evidence

The end-to-end suite found this (spec issue-3635). The first version of the Renames and rewrites check in #3685 used this flow. #3685 documents the gap in the Trace README and tests the amend and the rename separately.

主要语言
Go
星标
582
派生
61
平均合并
12 小时 47 分钟
30 天内合并 PR
137

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

chainloop-dev/chainloop 的其他 Issue

查看 chainloop-dev/chainloop 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。