Worker: an admission command that ranks or refuses local lease requests (ADR 0074 on the worker)

Offen
#1,744 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Anfängerfreundlichkeit
35/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
typescript
Bereich
api, backend

Rechercherichtung

Start with ADR 0074 and src/leasing/acquisition-admission.ts, then trace how gateway admission commands receive requests and how local worker lease requests are stored. The proposal also points to worker configuration and status reporting as entry points. Done means local requests support operator admission and fail closed if the controller stops, while existing leases and in-flight operations follow the stated use case.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

request:new

Problem

ADR 0074 lets a gateway run an operator admission command that ranks or refuses each new lease.request. On a host that runs a worker, though, local agents lease from the worker directly. So an operator who must hold the host's simulators for a scheduled workload (a CI train, a measurement run, maintenance) has no supported way to refuse new local provisioning.

Verified against v0.8.0:

  • docs reference/cli.mdx "Which daemon a command reaches": with neither --gateway nor --local, a command goes to the gateway only when no worker has started on the machine. So on a worker host the default CLI and MCP reach the worker.
  • gateway/joining-workers.mdx: "Agents on the worker machine still lease devices from it directly."
  • gateway/access-control.mdx: on the daemon's own machine the CLI needs no token.
  • source src/leasing/acquisition-admission.ts holds only internal checks (requester limit, lease ids). There is no operator hook on the worker.
  • worker drain exists only for gateways. On a standalone worker, capacity limits apply only at daemon start.

Context: the same shared-Mac setup as #1587 / #1737 (one Mac mini, one worker, ~10 concurrent coding agents, plus scheduled CI trains on the same host).

Use case

Before a train starts, the operator needs to:

  1. refuse new simulator/emulator provisioning (new leases, boots, installs);
  2. let boots already in flight finish and keep existing leases (no forced release);
  3. admit only the train's own requests while it runs (by request metadata);
  4. stop refusing when the train ends.

Hard requirement: fail closed if the controller dies. If the process that holds the reservation is killed or interrupted, new provisioning must stay refused until an operator or the controller clears it. It must never fall back to admitting.

Proposal

Mirror ADR 0074 on the worker:

  • admission.command (an argv list) and admission.timeoutMs in the worker config. The command runs once per new local lease.request, after the cheap refusals and before the request is stored. The stdin/stdout contract is the same as the gateway's ({} / {"priority": n} / {"deny": "reason"}), it receives the caller's metadata, and it fails closed with ADMISSION_FAILED.
  • Requests relayed by a gateway that already ran its own command can skip the worker's command (configurable).
  • Optional simpler switch: worker drain on a standalone worker (refuse new local leases, keep existing ones).
  • Status exposes in-flight lifecycle operations (booting/creating/installing), so a controller can wait for them to settle before it takes ownership.

Alternatives considered

  • A same-host gateway with an admission command: local agents bypass it (see above).
  • Running the worker from a separate SIMLOCK_HOME so the default CLI resolves to the gateway: possible, but it relocates device state and puts a gateway hop on every local simctl/adb/install.
  • Restarting the daemon with lower capacity limits: needs 0 leases and a restart each time.

Environment: Simlock 0.5.0 (planning 0.8.0), macOS 27.2, Xcode 27.2, single-host worker.

Vorherrschende Sprache
TypeScript
Sterne
705
Forks
40
Ø Merge
12 Std. 9 Min.
Gemergte PRs (30 T.)
376

Entwicklungsumgebung

Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus callstackincubator/simlock

Alle Issues in callstackincubator/simlock

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.