Worker: an admission command that ranks or refuses local lease requests (ADR 0074 on the worker)

Đang mở
#1,744 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
5/5
Thời gian dự kiến
Hơn một tuần
Mức phù hợp với người mới
35/100
Loại issue
Tính năng
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
typescript
Lĩnh vực
api, backend

Hướng nghiên cứu

Start with ADR 0074 and src/leasing/acquisition-admission.ts, then trace how gateway admission commands receive requests and how local worker lease requests are stored. The proposal also points to worker configuration and status reporting as entry points. Done means local requests support operator admission and fail closed if the controller stops, while existing leases and in-flight operations follow the stated use case.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

request:new

Problem

ADR 0074 lets a gateway run an operator admission command that ranks or refuses each new lease.request. On a host that runs a worker, though, local agents lease from the worker directly. So an operator who must hold the host's simulators for a scheduled workload (a CI train, a measurement run, maintenance) has no supported way to refuse new local provisioning.

Verified against v0.8.0:

  • docs reference/cli.mdx "Which daemon a command reaches": with neither --gateway nor --local, a command goes to the gateway only when no worker has started on the machine. So on a worker host the default CLI and MCP reach the worker.
  • gateway/joining-workers.mdx: "Agents on the worker machine still lease devices from it directly."
  • gateway/access-control.mdx: on the daemon's own machine the CLI needs no token.
  • source src/leasing/acquisition-admission.ts holds only internal checks (requester limit, lease ids). There is no operator hook on the worker.
  • worker drain exists only for gateways. On a standalone worker, capacity limits apply only at daemon start.

Context: the same shared-Mac setup as #1587 / #1737 (one Mac mini, one worker, ~10 concurrent coding agents, plus scheduled CI trains on the same host).

Use case

Before a train starts, the operator needs to:

  1. refuse new simulator/emulator provisioning (new leases, boots, installs);
  2. let boots already in flight finish and keep existing leases (no forced release);
  3. admit only the train's own requests while it runs (by request metadata);
  4. stop refusing when the train ends.

Hard requirement: fail closed if the controller dies. If the process that holds the reservation is killed or interrupted, new provisioning must stay refused until an operator or the controller clears it. It must never fall back to admitting.

Proposal

Mirror ADR 0074 on the worker:

  • admission.command (an argv list) and admission.timeoutMs in the worker config. The command runs once per new local lease.request, after the cheap refusals and before the request is stored. The stdin/stdout contract is the same as the gateway's ({} / {"priority": n} / {"deny": "reason"}), it receives the caller's metadata, and it fails closed with ADMISSION_FAILED.
  • Requests relayed by a gateway that already ran its own command can skip the worker's command (configurable).
  • Optional simpler switch: worker drain on a standalone worker (refuse new local leases, keep existing ones).
  • Status exposes in-flight lifecycle operations (booting/creating/installing), so a controller can wait for them to settle before it takes ownership.

Alternatives considered

  • A same-host gateway with an admission command: local agents bypass it (see above).
  • Running the worker from a separate SIMLOCK_HOME so the default CLI resolves to the gateway: possible, but it relocates device state and puts a gateway hop on every local simctl/adb/install.
  • Restarting the daemon with lower capacity limits: needs 0 leases and a restart each time.

Environment: Simlock 0.5.0 (planning 0.8.0), macOS 27.2, Xcode 27.2, single-host worker.

Ngôn ngữ chính
TypeScript
Star
705
Fork
40
Merge trung bình
12 giờ 9 phút
Pull request đã merge (30 ngày)
376

Chuẩn bị môi trường

Dự án này không cung cấp dev container, Dockerfile hay hướng dẫn đóng góp, nên bạn cần tự thiết lập môi trường: hãy bắt đầu từ README và xem hướng dẫn đóng góp lần đầu của chúng tôi để biết các bước chung.

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của callstackincubator/simlock

Tất cả issue của callstackincubator/simlock

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.