[bot] Anthropic MCP connector tool calls (mcp_tool_use/mcp_tool_result) produce broken, input-less child spans
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Anfängerfreundlichkeit
- 82/100
- Issue-Typ
- Bug
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- java
- Bereich
- observability
Rechercherichtung
Beginne in InstrumentationSemConv.addAnthropicServerSideChildSpans in braintrust-sdk/src/main/java/dev/braintrust/instrumentation/InstrumentationSemConv.java, wo Blöcke durch type dispatcht werden; lies auch ANTHROPIC_SERVER_TOOL_USE_TYPE, isAnthropicToolResultType und die call == null-Fallbacks. Registriere mcp_tool_use als Aufruftyp, damit die bestehende suffixbasierte Ergebniszuordnung es mit mcp_tool_result paart. Spiegle die bestehende server_tool_use-Abdeckung in BraintrustAnthropicServerSideSpansTest.java und führe diese Testklasse aus; fertig bedeutet, dass der MCP-Child-Span den echten Toolnamen und input_json trägt.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Summary
InstrumentationSemConv.addAnthropicServerSideChildSpans dispatches Anthropic Messages response content blocks by checking each block's "type" against the literal string "server_tool_use" (see ANTHROPIC_SERVER_TOOL_USE_TYPE and the dispatch check). Anthropic's MCP connector feature emits a different, distinct pair of block types for server-executed MCP tool calls: "mcp_tool_use" (the call) and "mcp_tool_result" (the result). "mcp_tool_use" does not match the "server_tool_use" check, so it is never registered in the call-tracking map used to pair calls with results.
Meanwhile "mcp_tool_result" does match the result-type check, which is a suffix check (type.endsWith("_tool_result") && !type.equals("tool_result")). So the result proceeds through the pairing logic, never finds its matching call, and is emitted alone with call == null.
Consequence for every MCP connector tool invocation:
- The child span is named generically
"mcp_tool"(derived by stripping"_tool_result"off the result's type) instead of the real tool name, because the fallback naming path only runs whencall == null. input_jsonis never set on the span, because the input-extraction path also returnsnullwhencall == null. The tool'sname,server_name, andinputarguments — which live only in the droppedmcp_tool_useblock — are permanently lost from the structured child span.
The raw response body is still present in the parent LLM span's full JSON passthrough, so the data isn't gone from Braintrust entirely, but the per-tool-call child span that Braintrust's UI specifically surfaces for tool calls is broken for every MCP connector invocation — call name and input are unrecoverable from that span.
Braintrust docs status: supported
Braintrust's docs at https://www.braintrust.dev/docs/integrations/ai-providers/anthropic describe this capability for the Python SDK: tool calls (including MCP connector tool calls) are captured "with its input and result ... named after the tool" as dedicated spans. This confirms the capability is documented/expected, just not delivered correctly by the Java SDK.
Why this isn't speculative
The identical bug (same mechanism: literal match on "server_tool_use", suffix-based result matching that doesn't require a paired call) was already found and fixed in Braintrust's Python SDK — see braintrustdata/braintrust-sdk-python#797 (fixed in py-sdk-v0.44.1) — and is tracked as still-open for the Go SDK in braintrustdata/braintrust-sdk-go#107. The fix was never ported to the Java SDK.
Upstream sources
- https://docs.anthropic.com/en/docs/agents-and-tools/mcp-connector — documents the
mcp_tool_use/mcp_tool_resultcontent block shapes (e.g.{"type":"mcp_tool_use","id":"mcptoolu_...","name":"<tool>","server_name":"<server>","input":{...}}), distinct fromserver_tool_use. - https://github.com/anthropics/anthropic-sdk-java/blob/v2.2.0/anthropic-java-core/src/main/kotlin/com/anthropic/models/beta/messages/BetaContentBlock.kt — confirms these block types were already modeled in the Anthropic Java SDK at the version this repo pins (2.2.0). This instrumentation parses raw JSON directly rather than typed SDK objects, so the gap is a pure string-literal dispatch miss, not an SDK-version-currency issue.
- https://github.com/braintrustdata/braintrust-sdk-python/issues/797 — identical bug, already fixed in the Python SDK.
- https://github.com/braintrustdata/braintrust-sdk-go/issues/107 — same class of bug, open in the Go SDK.
Local repo files inspected
braintrust-sdk/src/main/java/dev/braintrust/instrumentation/InstrumentationSemConv.java—ANTHROPIC_SERVER_TOOL_USE_TYPEconstant and dispatch check;addAnthropicServerSideChildSpans(call registration loop);isAnthropicToolResultType(suffix-based result matching);emitAnthropicServerToolSpan,anthropicToolSpanName,anthropicToolSpanInput(fallback behavior whencall == null).braintrust-sdk/instrumentation/anthropic_2_2_0/src/test/java/dev/braintrust/instrumentation/anthropic/v2_2_0/BraintrustAnthropicServerSideSpansTest.java— only exercisesweb_search/server_tool_use; nomcp_tool_use/mcp_tool_resulttest coverage exists.- Repo-wide search for
mcp_tool_use/mcp_tool_result/ "MCP connector" — zero matches outside this finding.
Suggested fix
Recognize "mcp_tool_use" as an additional call-type alongside "server_tool_use" when populating the call-tracking map (the existing suffix-based result matching already handles "mcp_tool_result" correctly once a matching call is registered), and add a test mirroring the existing server_tool_use test for the MCP connector block pair.
- Vorherrschende Sprache
- Java
- Sterne
- 21
- Forks
- 5
- Ø Merge
- 1 T. 1 Std.
- Gemergte PRs (30 T.)
- 5
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus braintrustdata/braintrust-sdk-java
-
java
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 80/100
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
-
java
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 45/100
-
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 35/100
Alle Issues in braintrustdata/braintrust-sdk-java
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
oracle/graalvm-reachability-metadata#11472 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 89/100
objectionary/hone-maven-plugin#1353 ·
Maintainer antworten meist innerhalb von 9 Tagen
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 88/100
Maintainer antworten meist innerhalb von 1 Tag
-
Update samples to Citrus 5.1.0Evtl. vergeben @asuruceanu hat das heute übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
apache/doris#69863 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag