[bot] Anthropic MCP connector tool calls (mcp_tool_use/mcp_tool_result) produce broken, input-less child spans
Avaliação
- Dificuldade
- 2/5
- Tempo estimado
- 1-3 horas
- Facilidade para iniciantes
- 82/100
- Tipo de issue
- Bug
- Clareza
- Claramente especificada
- Status de atividade
- Ativa
- Stack de tecnologia
- java
- Domínio
- observability
Direção de pesquisa
Comece em InstrumentationSemConv.addAnthropicServerSideChildSpans em braintrust-sdk/src/main/java/dev/braintrust/instrumentation/InstrumentationSemConv.java, onde os blocos são despachados por type; leia também ANTHROPIC_SERVER_TOOL_USE_TYPE, isAnthropicToolResultType e os fallbacks de call == null. Registre mcp_tool_use como um tipo de chamada para que a correspondência de resultados baseada em sufixo existente o emparelhe com mcp_tool_result. Espelhe a cobertura existente de server_tool_use em BraintrustAnthropicServerSideSpansTest.java e execute essa classe de teste; concluído significa que o span filho MCP carrega o nome real da ferramenta e input_json.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Summary
InstrumentationSemConv.addAnthropicServerSideChildSpans dispatches Anthropic Messages response content blocks by checking each block's "type" against the literal string "server_tool_use" (see ANTHROPIC_SERVER_TOOL_USE_TYPE and the dispatch check). Anthropic's MCP connector feature emits a different, distinct pair of block types for server-executed MCP tool calls: "mcp_tool_use" (the call) and "mcp_tool_result" (the result). "mcp_tool_use" does not match the "server_tool_use" check, so it is never registered in the call-tracking map used to pair calls with results.
Meanwhile "mcp_tool_result" does match the result-type check, which is a suffix check (type.endsWith("_tool_result") && !type.equals("tool_result")). So the result proceeds through the pairing logic, never finds its matching call, and is emitted alone with call == null.
Consequence for every MCP connector tool invocation:
- The child span is named generically
"mcp_tool"(derived by stripping"_tool_result"off the result's type) instead of the real tool name, because the fallback naming path only runs whencall == null. input_jsonis never set on the span, because the input-extraction path also returnsnullwhencall == null. The tool'sname,server_name, andinputarguments — which live only in the droppedmcp_tool_useblock — are permanently lost from the structured child span.
The raw response body is still present in the parent LLM span's full JSON passthrough, so the data isn't gone from Braintrust entirely, but the per-tool-call child span that Braintrust's UI specifically surfaces for tool calls is broken for every MCP connector invocation — call name and input are unrecoverable from that span.
Braintrust docs status: supported
Braintrust's docs at https://www.braintrust.dev/docs/integrations/ai-providers/anthropic describe this capability for the Python SDK: tool calls (including MCP connector tool calls) are captured "with its input and result ... named after the tool" as dedicated spans. This confirms the capability is documented/expected, just not delivered correctly by the Java SDK.
Why this isn't speculative
The identical bug (same mechanism: literal match on "server_tool_use", suffix-based result matching that doesn't require a paired call) was already found and fixed in Braintrust's Python SDK — see braintrustdata/braintrust-sdk-python#797 (fixed in py-sdk-v0.44.1) — and is tracked as still-open for the Go SDK in braintrustdata/braintrust-sdk-go#107. The fix was never ported to the Java SDK.
Upstream sources
- https://docs.anthropic.com/en/docs/agents-and-tools/mcp-connector — documents the
mcp_tool_use/mcp_tool_resultcontent block shapes (e.g.{"type":"mcp_tool_use","id":"mcptoolu_...","name":"<tool>","server_name":"<server>","input":{...}}), distinct fromserver_tool_use. - https://github.com/anthropics/anthropic-sdk-java/blob/v2.2.0/anthropic-java-core/src/main/kotlin/com/anthropic/models/beta/messages/BetaContentBlock.kt — confirms these block types were already modeled in the Anthropic Java SDK at the version this repo pins (2.2.0). This instrumentation parses raw JSON directly rather than typed SDK objects, so the gap is a pure string-literal dispatch miss, not an SDK-version-currency issue.
- https://github.com/braintrustdata/braintrust-sdk-python/issues/797 — identical bug, already fixed in the Python SDK.
- https://github.com/braintrustdata/braintrust-sdk-go/issues/107 — same class of bug, open in the Go SDK.
Local repo files inspected
braintrust-sdk/src/main/java/dev/braintrust/instrumentation/InstrumentationSemConv.java—ANTHROPIC_SERVER_TOOL_USE_TYPEconstant and dispatch check;addAnthropicServerSideChildSpans(call registration loop);isAnthropicToolResultType(suffix-based result matching);emitAnthropicServerToolSpan,anthropicToolSpanName,anthropicToolSpanInput(fallback behavior whencall == null).braintrust-sdk/instrumentation/anthropic_2_2_0/src/test/java/dev/braintrust/instrumentation/anthropic/v2_2_0/BraintrustAnthropicServerSideSpansTest.java— only exercisesweb_search/server_tool_use; nomcp_tool_use/mcp_tool_resulttest coverage exists.- Repo-wide search for
mcp_tool_use/mcp_tool_result/ "MCP connector" — zero matches outside this finding.
Suggested fix
Recognize "mcp_tool_use" as an additional call-type alongside "server_tool_use" when populating the call-tracking map (the existing suffix-based result matching already handles "mcp_tool_result" correctly once a matching call is registered), and add a test mirroring the existing server_tool_use test for the MCP connector block pair.
- Linguagem predominante
- Java
- Estrelas
- 21
- Forks
- 5
- Merge médio
- 1d 1h
- PRs com merge (30d)
- 5
Preparar o ambiente
- Sem Dockerfile nem arquivo Docker Compose
- Sem modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de braintrustdata/braintrust-sdk-java
-
java
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 80/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 82/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
-
java
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 45/100
-
Dificuldade 5/5 Mais de uma semana Facilidade para iniciantes 35/100
Todas as issues de braintrustdata/braintrust-sdk-java
Issues semelhantes
-
bug/错误
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 64/100
FCL-Team/FoldCraftLauncher#1982 · 2 comentários ·
Mantenedores costumam responder em até 1 dia
-
[BUG] micronaut-serde-oracle-jdbc-json brings a second OJDBC driver onto the runtime classpathTalvez já em andamento @ZARAYACH assumiu hoje. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
micronaut-projects/micronaut-serialization#1494 · 4 comentários ·
Mantenedores costumam responder em até 2 dias
-
bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 73/100
Mantenedores costumam responder em até 2 dias
-
bug
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 85/100
vitruv-tools/Vitruv-Change#600 ·
Mantenedores costumam responder em até 1 dia
-
code-health feature/sync OS/Android QA/Test-Plan-Specified QA/Yes
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
brave/brave-browser#60327 ·
Mantenedores costumam responder em até 1 dia