kubernetes: make the terminating-pod policy configurable in pods mode

Offen
#224 0 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
53/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
elixir, kubernetes

Rechercherichtung

Start by reading the Kubernetes strategy code for pods mode and the change associated with issue #114, which introduced the current terminating-pod behavior. Trace how pod deletion timestamps and running state affect discovery, then check the strategy tests and configuration documentation. Done means an opt-in :include setting keeps running terminating pods visible while the default :exclude behavior remains unchanged.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Steps to reproduce
  • Configuration Used: Cluster.Strategy.Kubernetes with kubernetes_ip_lookup_mode: :pods.
  • Strategy Used: Cluster.Strategy.Kubernetes (pods mode).
  • Errors/Incorrect Behaviour Encountered: the terminating-pod policy is fixed. 3.6.0 excludes pods with a metadata.deletionTimestamp, which is the right default for deployments that want an unreachable target removed quickly.
Description of issue

This is an improvement request, not a bug: make the terminating-pod policy configurable in pods mode, keeping 3.6.0 as the default. 3.6.0 introduced the current behavior to address #114, but it also removed the ability to express the opposite case.

The use case is a distributed application where a node has to stay reachable while it shuts down. Process groups are one example: if a node leaves discovery as soon as its pod is marked for deletion, it can disappear from :pg before it has finished draining, and peers may start replacement processes while the old ones are still unwinding. Other examples are a node handing off a lease, or a supervised job it owns, before it goes away.

Today there is no way to keep that node visible: pods mode removes it, and endpoints and EndpointSlice modes drop terminating endpoints too. A field selector can't express it either, because a terminating pod keeps phase: Running and metadata.deletionTimestamp is not a selectable field.

Would an opt-in option be acceptable?

kubernetes_pod_terminating: :exclude | :include
  • :exclude (default): current behavior, remove a pod as soon as it has a deletionTimestamp.
  • :include: keep it until it is no longer Running, which is what a draining node needs.

The documentation is correct for the default; this would add an option instead of changing behavior.

Vorherrschende Sprache
Elixir
Sterne
2.2k
Forks
202
Ø Merge
2 Min.
Gemergte PRs (30 T.)
1

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus bitwalker/libcluster

Alle Issues in bitwalker/libcluster

Ähnliche Issues

Weitere Issues zu Elixir

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.