kubernetes: make the terminating-pod policy configurable in pods mode

Aperta
#224 0 commenti 1 reazione 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
53/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
elixir, kubernetes

Direzione di ricerca

Start by reading the Kubernetes strategy code for pods mode and the change associated with issue #114, which introduced the current terminating-pod behavior. Trace how pod deletion timestamps and running state affect discovery, then check the strategy tests and configuration documentation. Done means an opt-in :include setting keeps running terminating pods visible while the default :exclude behavior remains unchanged.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Steps to reproduce
  • Configuration Used: Cluster.Strategy.Kubernetes with kubernetes_ip_lookup_mode: :pods.
  • Strategy Used: Cluster.Strategy.Kubernetes (pods mode).
  • Errors/Incorrect Behaviour Encountered: the terminating-pod policy is fixed. 3.6.0 excludes pods with a metadata.deletionTimestamp, which is the right default for deployments that want an unreachable target removed quickly.
Description of issue

This is an improvement request, not a bug: make the terminating-pod policy configurable in pods mode, keeping 3.6.0 as the default. 3.6.0 introduced the current behavior to address #114, but it also removed the ability to express the opposite case.

The use case is a distributed application where a node has to stay reachable while it shuts down. Process groups are one example: if a node leaves discovery as soon as its pod is marked for deletion, it can disappear from :pg before it has finished draining, and peers may start replacement processes while the old ones are still unwinding. Other examples are a node handing off a lease, or a supervised job it owns, before it goes away.

Today there is no way to keep that node visible: pods mode removes it, and endpoints and EndpointSlice modes drop terminating endpoints too. A field selector can't express it either, because a terminating pod keeps phase: Running and metadata.deletionTimestamp is not a selectable field.

Would an opt-in option be acceptable?

kubernetes_pod_terminating: :exclude | :include
  • :exclude (default): current behavior, remove a pod as soon as it has a deletionTimestamp.
  • :include: keep it until it is no longer Running, which is what a draining node needs.

The documentation is correct for the default; this would add an option instead of changing behavior.

Lingua principale
Elixir
Stelle
2.2k
Fork
202
Merge medio
2m
PR unite (30g)
1

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di bitwalker/libcluster

Tutte le issue di bitwalker/libcluster

Issue simili

Altre issue su Elixir

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.